Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Speed up visit_structured_query() by 1,948% in libs/langchain/langchain/retrievers/self_query/myscale.py #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

⚡️ Speed up visit_structured_query() by 1,948% in libs/langchain/langchain/retrievers/self_query/myscale.py #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
⚡️ Speed up visit_structured_query by 1,948%
@codeflash-ai
codeflash-ai[bot] authored Feb 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit aac404a86afe838049dae9fb21622330c90badbf
10 changes: 5 additions & 5 deletions libs/langchain/langchain/retrievers/self_query/myscale.py
View file
Original file line number Diff line number Diff line change
@@ -117,9 +117,9 @@ def visit_comparison(self, comparison: Comparison) -> Dict:
def visit_structured_query(
self, structured_query: StructuredQuery
) -> Tuple[str, dict]:
print(structured_query)
if structured_query.filter is None:
kwargs = {}
else:
kwargs = {"where_str": structured_query.filter.accept(self)}
kwargs = (
{"where_str": structured_query.filter.accept(self)}
if structured_query.filter is not None
else {}
)
return structured_query.query, kwargs