-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Engine CPS #42
feat: Engine CPS #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we merge this immediately so that it doesn't block anyone else. It's not super useful for me to force the review loop now imo. Also, at a first glance there's nothing suspicious here anyways so I think this is fine to merge now.
What I'll probably do is make a separate PR that cleans up some of the documentation (mainly so I can get a better understanding of everything, but also to clean up).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have the mock tests!
Making the engine CPS so that it fits properly with the optimizer pub/sub model.
This is in fact a simplication of the codebase.