Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Engine CPS #42

Merged
merged 13 commits into from
Mar 14, 2025
Merged

feat: Engine CPS #42

merged 13 commits into from
Mar 14, 2025

Conversation

AlSchlo
Copy link
Collaborator

@AlSchlo AlSchlo commented Mar 13, 2025

Making the engine CPS so that it fits properly with the optimizer pub/sub model.

This is in fact a simplication of the codebase.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 81.67098% with 283 lines in your changes missing coverage. Please review.

Project coverage is 73.3%. Comparing base (03e6b1d) to head (deec19a).

Files with missing lines Patch % Lines
optd-core/src/engine/mod.rs 2.9% 99 Missing ⚠️
optd-core/src/optimizer/subscriptions.rs 0.0% 74 Missing ⚠️
optd-core/src/optimizer/generator.rs 0.0% 42 Missing ⚠️
optd-core/src/optimizer/handlers.rs 0.0% 23 Missing ⚠️
optd-core/src/engine/eval/expr.rs 95.0% 21 Missing ⚠️
optd-core/src/optimizer/ingest.rs 0.0% 20 Missing ⚠️
optd-core/src/optimizer/mod.rs 0.0% 2 Missing ⚠️
optd-core/src/engine/eval/binary.rs 0.0% 1 Missing ⚠️
optd-core/src/engine/eval/mod.rs 96.5% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
optd-core/src/bridge/from_cir.rs 0.0% <ø> (ø)
optd-core/src/engine/eval/core.rs 100.0% <100.0%> (+9.9%) ⬆️
optd-core/src/engine/eval/match.rs 99.0% <ø> (+4.6%) ⬆️
optd-core/src/engine/eval/operator.rs 100.0% <100.0%> (+67.1%) ⬆️
optd-core/src/engine/test_utils.rs 100.0% <100.0%> (ø)
optd-core/src/engine/utils.rs 100.0% <100.0%> (ø)
optd-core/src/engine/eval/binary.rs 80.7% <0.0%> (ø)
optd-core/src/engine/eval/mod.rs 96.6% <96.5%> (ø)
optd-core/src/optimizer/mod.rs 0.0% <0.0%> (ø)
optd-core/src/optimizer/ingest.rs 0.0% <0.0%> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlSchlo AlSchlo marked this pull request as ready for review March 14, 2025 03:38
@AlSchlo AlSchlo changed the title (feat) Engine CPS feat: Engine CPS Mar 14, 2025
Copy link
Member

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we merge this immediately so that it doesn't block anyone else. It's not super useful for me to force the review loop now imo. Also, at a first glance there's nothing suspicious here anyways so I think this is fine to merge now.

What I'll probably do is make a separate PR that cleans up some of the documentation (mainly so I can get a better understanding of everything, but also to clean up).

Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have the mock tests!

@connortsui20 connortsui20 merged commit 60c275f into main Mar 14, 2025
11 checks passed
@connortsui20 connortsui20 deleted the alexis/engine-cps branch March 14, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants