Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.19 #92

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Upgrade to Go 1.19 #92

merged 1 commit into from
Dec 13, 2022

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented Dec 13, 2022

This PR upgrades Go to version 1.19.

@samcoe samcoe self-assigned this Dec 13, 2022
@samcoe samcoe requested a review from mislav December 13, 2022 06:40
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you. Ref. cli/cli#6723

This is a backwards-incompatible change, but I don't think it's worth bumping the major version number. Do you think bumping just the minor version is fine?

@samcoe
Copy link
Contributor Author

samcoe commented Dec 13, 2022

@mislav I think a minor version bump is acceptable.

@samcoe samcoe merged commit da64a13 into trunk Dec 13, 2022
@samcoe samcoe deleted the go-1.19 branch December 13, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants