Add support to config for setting and writing blank values #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfeller
approved these changes
Oct 26, 2023
Comment on lines
+124
to
+128
| val := yamlmap.StringValue(value) | ||
| if value == "" { | ||
| val = yamlmap.NullValue() | ||
| } | ||
| m.SetEntry(keys[len(keys)-1], val) |
There was a problem hiding this comment.
Initially, I assumed we'd have the ability to set the config to null values, not that all empty strings will be null values.
I don't know a definitive way this will be a problem assuming this is YAML and should hopefully work 🤞
There was a problem hiding this comment.
It is YAML so they are more or less equivalent, which is why I went this direction instead of introducing a new function like SetNull. It felt mostly like implementation detail that the user shouldn't be concerned with. The user still receives an empty string using Get if they Set an empty string which felt like the only contract that we need to maintain here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the implementation of
config.Setto set null yaml values instead of blank strings when passed a blank string as a value argument. We are not relying on the previous behavior anywhere and this allows us to create config keys even if they do not have any nested keys yet. We already work around this limitation in auth login and we can finally remove that code. Additionally this is necessary for the work being done in this branch which is not quiet ready for a PR yet.