feat: dynamic infrastructure clusters patching #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
prometherion
force-pushed
the
feat/dynamic-infracluster-patch
branch
3 times, most recently
from
89882ab to
707cb45
Compare
Signed-off-by: Dario Tranchitella <[email protected]>
prometherion
force-pushed
the
feat/dynamic-infracluster-patch
branch
from
707cb45 to
281507d
Compare
|
Sharing as a note: when specifying a dynamic infrastructure cluster, the CP provider must be granted the required RBAC which isn't managed in the CAPI manifest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature request introduces a feature togglable via the Feature Flag
DynamicInfrastructureClusterPatchwhich allows patching any Infrastructure Cluster specified in the CLI flag--infrastructure-clusterswhich accepts a comma-separated list of Kubernetes API object kinds.This feature is useful for developers aiming to integrate Kamaji within their organizations where a Cluster API infrastructure provider is not public.
Upon installation, a proper RBAC must be addressed here, otherwise patching would require a
*scope which isn't good from a threat modeling perspective.