Add support for "endless" rule #55
Merged
+220
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to Ruby's "endless" method. The goal is to allow simple rules to be more compact (similar also to JavaScript's bracket-less arrow functions). Being more compact (while still readable) allows more code to be seen at once and reduces keyword noise (lots of `end`s) and excess white space. These two things make it easier to scan and grok the grammar. This closes cjheath#54. See that issue for examples.
|
This was still problematic. The semantic predicate you added to ensure that the parsing_rule was all on one line actually looked at the text "rule", the first token, not the last one, which is the parsing rule. It was a little ugly and I improved that. This change has been pushed to master. Please peruse it there before I publish the gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to Ruby's "endless" method. The goal is to allow simple rules to be more compact (similar also to JavaScript's bracket-less arrow functions).
Being more compact (while still readable) allows more code to be seen at once and reduces keyword noise (lots of
ends) and excess white space. These two things make it easier to scan and grok the grammar.I've tested this in a project I am using Treetop for. It reduced the LOC for the Treetop files by 1/4 since a significant number of the rules were simple and could be expressed on a single line. This significantly reduced the scrolling to read the grammar.
This closes #54. See that issue for examples.