Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Twitter old logo to new X logo #815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ONKARBH
Copy link

@ONKARBH ONKARBH commented Feb 15, 2025

I will change the Twitter old logo and adding a new X logo

Screenshot 2025-02-15 125333

@ceph-jenkins
Copy link

Can one of the admins verify this patch?

@jmundack jmundack requested a review from ljflores February 16, 2025 18:21
@ljflores ljflores requested review from a team and djgalloway February 17, 2025 23:11
@djgalloway
Copy link
Contributor

djgalloway commented Feb 18, 2025

Is this required? Meaning, are we under any legal obligation to change the logo/name?

@ONKARBH
Copy link
Author

ONKARBH commented Feb 18, 2025

Is this required? Meaning, are we under any legal obligation to change the logo/name?

@djgalloway Thank you for reviewing the PR. While there may not be a strict legal obligation, updating the logo ensures that the Ceph website reflects the latest branding and maintains accuracy in external references. Since Twitter has officially rebranded to X, keeping outdated logos may cause inconsistency in our UI.

This is a minor but relevant update to enhance the website’s visual correctness. Let me know if any further modifications are needed. I appreciate your time and consideration.

@ONKARBH
Copy link
Author

ONKARBH commented Feb 26, 2025

Hello @ljflores and @djgalloway,

I appreciate your time reviewing this PR. Please let me know if any modifications are needed to move forward with the merge. Looking forward to your feedback.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants