-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main exit #912
main exit #912
Conversation
2cdae48
to
6551853
Compare
1. Do not catch System exit 2. Return exit code 0 from TERM signal handler partial revert of - 6c120cf - 042cf8c Signed-off-by: Alexander Indenbaum <[email protected]>
25f8504
to
5522e1d
Compare
Signed-off-by: Alexander Indenbaum <[email protected]>
Signed-off-by: Alexander Indenbaum <[email protected]>
Teuthology run: https://pulpito.ceph.com/vallariag-2024-10-22_17:54:08-nvmeof-main-distro-default-smithi/ Explanation of 1 failed job: |
@VallariAg does it add a test to verify that if a gw exits with a bad status its being restarted? I guess no? |
@caroav it includes HA testing (thrasher test) and that passed. Do you mean self-restart after thrashing? (if yes, then yeah, we are not checking for self-restart - let me know and I can add that) |
this is a trashing case that we still need to add testing for in atom and teuthology. We need to kill one of {spdk, monitor client}, and see that the gw is exiting, but then being restarted automatically. Both cases should be checked (kill spdk, and in another iteration kill monitor client). |
@caroav ah okay, understood, will talk to Barak about it too next week. thank you! |
main exit
partial revert of