Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate listener's IP address before adding it #1065

Closed
gbregman opened this issue Jan 29, 2025 · 0 comments · Fixed by #1067
Closed

Validate listener's IP address before adding it #1065

gbregman opened this issue Jan 29, 2025 · 0 comments · Fixed by #1067
Assignees

Comments

@gbregman
Copy link
Collaborator

When we run a "listener add" command using an invalid IP address the error code we get back from SPDK is a generic one "invalid parameters". We can't tell what was the actual problem. We can validate the IP address in the gateway. Iterating the available ethernet interfaces and checking that the IP address we got is one of the ones on that list. We should allow the user to disable this validation by setting a flag in the configuration.

@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Jan 29, 2025
@gbregman gbregman self-assigned this Jan 29, 2025
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 30, 2025
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 30, 2025
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 30, 2025
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 30, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant