Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the actual SPDK version in "gw info" #1049

Closed
gbregman opened this issue Jan 22, 2025 · 0 comments · Fixed by #1056
Closed

Display the actual SPDK version in "gw info" #1049

gbregman opened this issue Jan 22, 2025 · 0 comments · Fixed by #1056
Assignees
@gbregman

Comments

@gbregman
Copy link
Collaborator

Right now we display the SPDK version we get from the environment. This might be wrong in case we deployed a different SPDK than the one we built with the gateway. We should fetch the actual SPDK version from the SPDK itself like we do for CEPH.

See BZ #2280213
@gbregman gbregman self-assigned this Jan 22, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Jan 22, 2025
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 22, 2025
@gbregman
Get SPDK version from SPDK and not the environment.
674b529 
Fixes ceph#1049

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Jan 22, 2025
Merged
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 22, 2025
@gbregman
Get SPDK version from SPDK and not the environment.
7b7443c 
Fixes ceph#1049

Signed-off-by: Gil Bregman <[email protected]>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 23, 2025
@gbregman
Get SPDK version from SPDK and not the environment.
ea029ce 
Fixes ceph#1049

Signed-off-by: Gil Bregman <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get SPDK version from SPDK and not the environment gbregman/ceph-nvmeof
1 participant
@gbregman