cephfs: return correct error message #4858
Conversation
return SnapshotOperationAlreadyExistsFmt instead of VolumeOperationAlreadyExistsFmt incase of delete snapshot operation. Signed-off-by: yati1998 <[email protected]>
| @@ -1067,7 +1067,7 @@ func (cs *ControllerServer) DeleteSnapshot( | |||
| if acquired := cs.SnapshotLocks.TryAcquire(sid.RequestName); !acquired { | |||
| log.ErrorLog(ctx, util.SnapshotOperationAlreadyExistsFmt, sid.RequestName) | |||
|
|
|||
| return nil, status.Errorf(codes.Aborted, util.VolumeOperationAlreadyExistsFmt, sid.RequestName) | |||
| return nil, status.Errorf(codes.Aborted, util.SnapshotOperationAlreadyExistsFmt, sid.RequestName) | |||
There was a problem hiding this comment.
can you please fix the same for groupsnapshot as well?
There was a problem hiding this comment.
we are taking volumelocks for it, please look into it as need to take snapshot locks. please take care of this as a new PR.
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 29aecd3 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
return SnapshotOperationAlreadyExistsFmt instead of VolumeOperationAlreadyExistsFmt incase of delete snapshot operation.