rbd: add backend support for VolumeGroup operations #4719
Conversation
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
b71a67e to
beaf170
Compare
| librbd "github.com/ceph/go-ceph/rbd" | ||
|
|
||
| "github.com/ceph/ceph-csi/internal/rbd/types" |
There was a problem hiding this comment.
rearrange the order here? cephcsi import should come first
There was a problem hiding this comment.
this guideline is not followed everywere. I think and Golang suggests to have imports of local packages at the bottom, that seems to be a coding convention many other Go projects use.
There was a problem hiding this comment.
https://github.com/ceph/ceph-csi/blob/devel/docs/coding.md#imports this is one we have, lets stick to it and also update other places if its not followed as followup cleanup?
There was a problem hiding this comment.
See #4721. I don't think we should strictly enforce it for existing imports, but it would be nice to use this order in new files.
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
2 times, most recently
from
dc80fab to
7a758aa
Compare
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
7a758aa to
a34d7fe
Compare
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
a34d7fe to
eca8a7a
Compare
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
eca8a7a to
5c8bdb0
Compare
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
6dec5e0 to
e214d05
Compare
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
e214d05 to
ccd5536
Compare
|
LGTM |
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
1bc0ca0 to
75ccdcc
Compare
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
2 times, most recently
from
5746225 to
f552d4d
Compare
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
f552d4d to
3362475
Compare
|
@Mergifyio rebase |
Add support for adding and removing the RBD-image from a group. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Add extra error checking to make sure trying to create an existing volume group does not result in a failure. The same counts for deleting a non-existing volume group, and adding/removing volumes to/from the volume group. Signed-off-by: Niels de Vos <[email protected]>
A RBD image can only be part of a single group. While an image is added to a group, check if the image is already part of a group, and return an error in case it is. Signed-off-by: Niels de Vos <[email protected]>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
csi-addons/rbd/volumegroup/journal
branch
from
3362475 to
1825c27
Compare
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
@Mergifyio requeue The multi-arch-build CI job failed while installing some packages. It has been restarted and has passed the section that previously failed. |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Describe what this PR does
Implementation of the VolumeGroup backend. It contains a clear separation of the VolumeGroup type and functions and CSI-Addons responsibilities.
Is there anything that requires special attention
Tested with a small application that calls the CSI-Addons procedures directly. The application was modified several times to test different scenarios. At the moment I am confident that the basic functionality works as expected.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)