rebase: Bump github.com/container-storage-interface/spec from 1.9.0 to 1.10.0 #4705

dependabot · 2024-07-08T20:57:16Z

Bumps github.com/container-storage-interface/spec from 1.9.0 to 1.10.0.

Release notes

Sourced from github.com/container-storage-interface/spec's releases.

v1.10.0

What's Changed

Breaking changes/Deprecations

None

Additions

[Alpha] Add new "SnapshotMetadata service" to allow CO to obtain allocated or changed block metadata for snapshots by @carlbraganza in container-storage-interface/spec#551

Clarifications/Corrections/Fixes

None

Dependencies

Update protoc and makefile by @huww98 in container-storage-interface/spec#552

Bump google.golang.org/grpc from 1.57.0 to 1.57.1 by @dependabot in container-storage-interface/spec#559

Bump golang.org/x/net from 0.10.0 to 0.23.0 by @dependabot in container-storage-interface/spec#564

Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 by @saad-ali in container-storage-interface/spec#566

New Contributors

@huww98 made their first contribution in container-storage-interface/spec#552

@carlbraganza made their first contribution in container-storage-interface/spec#551

Full Changelog: container-storage-interface/spec@v1.9.0...v1.10.0

v1.10.0-rc1

No release notes provided.

Commits

21be3f8 Merge pull request #566 from saad-ali/protoBufTo133
1bc2caf Bump google.golang.org/protobuf from 1.32.0 to 1.33.0
adb2b16 Merge pull request #564 from container-storage-interface/dependabot/go_module...
811799a Bump golang.org/x/net from 0.10.0 to 0.23.0
9674d35 Merge pull request #559 from container-storage-interface/dependabot/go_module...
2696773 Added the SnapshotMetadata service. (#551)
1f2bf8a Bump google.golang.org/grpc from 1.57.0 to 1.57.1
abf6346 update protoc and related (#552)
886cd48 Merge pull request #555 from saad-ali/release19bump
5855142 Bump master version to 1.10 for next release
See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

iPraveenParihar · 2024-07-10T06:33:49Z

lint failures,

internal/cephfs/groupcontrollerserver.go:181:9: copylocks: range var r copies lock: github.com/container-storage-interface/spec/lib/go/csi.CreateSnapshotResponse contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
	for _, r := range *resp {
	       ^
internal/cephfs/groupcontrollerserver.go:284:49: copylocks: call of append copies lock value: github.com/container-storage-interface/spec/lib/go/csi.CreateSnapshotResponse contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
		snapshotResponses = append(snapshotResponses, *resp)
		                                              ^
internal/cephfs/groupcontrollerserver.go:294:9: copylocks: range var r copies lock: github.com/container-storage-interface/spec/lib/go/csi.CreateSnapshotResponse contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
	for _, r := range snapshotResponses {
level=info msg="File cache stats: 209 entries of total size 1.7MiB"
level=info msg="Memory: 1523 samples, avg is 818.6MB, max is 3861.9MB"
level=info msg="Execution took 2m45.7009854s"
	       ^
internal/cephfs/groupcontrollerserver.go:348:33: copylocks: call of append copies lock value: github.com/container-storage-interface/spec/lib/go/csi.CreateSnapshotResponse contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
		responses = append(responses, *resp)
		                              ^
internal/util/topology.go:214:19: copylocks: call of fmt.Errorf copies lock value: github.com/container-storage-interface/spec/lib/go/csi.TopologyRequirement contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
		*topologyPools, *accessibilityRequirements)

csi.CreateSnapshotResponse embed DoNotCopy struct, more on DoNotCopy 👇

// DoNotCopy can be embedded in a struct to help prevent shallow copies.
// This does not rely on a Go language feature, but rather a special case
// within the vet checker.
//
// See https://golang.org/issues/8005.

nixpanic · 2024-07-10T08:06:46Z

@Mergifyio rebase

Bumps [github.com/container-storage-interface/spec](https://github.com/container-storage-interface/spec) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/container-storage-interface/spec/releases) - [Commits](container-storage-interface/spec@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/container-storage-interface/spec dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

The DefaultIdentityServer struct embedded UnimplementedControllerServer, but it should have been UnimplementedIdentityServer instead. Signed-off-by: Niels de Vos <[email protected]>

This commit resolves the govet issue - `copylocks: call of append copies lock value ... contains sync.Mutex` Embedding DoNotCopy in a struct is a convention to signal and prevent shallow copies, as recommended in Go's best practices. This does not rely on a language feature but is instead a special case within the vet checker. For more details, see https://golang.org/issues/8005 Signed-off-by: Praveen M <[email protected]>

mergify · 2024-07-10T08:06:59Z

rebase

✅ Branch has been successfully rebased

nixpanic · 2024-07-10T08:14:54Z

@Mergifyio queue

mergify · 2024-07-10T08:14:56Z

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

ceph-csi-bot · 2024-07-10T08:15:08Z

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot · 2024-07-10T08:15:08Z

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot · 2024-07-10T08:15:09Z

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot · 2024-07-10T08:15:09Z

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot · 2024-07-10T08:15:09Z

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot · 2024-07-10T08:15:10Z

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot · 2024-07-10T08:15:10Z

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot · 2024-07-10T08:15:10Z

/test ci/centos/mini-e2e/k8s-1.30

ceph-csi-bot · 2024-07-10T08:15:10Z

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot · 2024-07-10T08:15:10Z

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot · 2024-07-10T08:15:11Z

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot · 2024-07-10T08:15:12Z

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot · 2024-07-10T08:15:13Z

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot · 2024-07-10T08:15:13Z

/test ci/centos/mini-e2e/k8s-1.29

nixpanic · 2024-07-10T10:35:25Z

/retest ci/centos/mini-e2e/k8s-1.28

nixpanic · 2024-07-10T10:37:01Z

/retest ci/centos/mini-e2e/k8s-1.28

Not sure why it failed... logs

nixpanic · 2024-07-10T10:37:14Z

@Mergifyio requeue

mergify · 2024-07-10T10:37:40Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

dependabot bot added the rebase update the version of an external component label Jul 8, 2024

iPraveenParihar force-pushed the dependabot/go_modules/github.com/container-storage-interface/spec-1.10.0 branch from 1caf176 to 94bb001 Compare July 10, 2024 06:39

iPraveenParihar requested a review from nixpanic July 10, 2024 06:41

nixpanic approved these changes Jul 10, 2024

View reviewed changes

nixpanic requested a review from a team July 10, 2024 08:06

dependabot bot and others added 3 commits July 10, 2024 08:06

util: DefaultIdentityServer should use csi.UnimplementedIdentityServer

91fbc58

The DefaultIdentityServer struct embedded UnimplementedControllerServer, but it should have been UnimplementedIdentityServer instead. Signed-off-by: Niels de Vos <[email protected]>

nixpanic force-pushed the dependabot/go_modules/github.com/container-storage-interface/spec-1.10.0 branch from 94bb001 to c510444 Compare July 10, 2024 08:06

nixpanic requested a review from iPraveenParihar July 10, 2024 08:12

iPraveenParihar approved these changes Jul 10, 2024

View reviewed changes

mergify bot added the ok-to-test Label to trigger E2E tests label Jul 10, 2024

ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 10, 2024

mergify bot merged commit d376271 into devel Jul 10, 2024
40 checks passed

dependabot bot deleted the dependabot/go_modules/github.com/container-storage-interface/spec-1.10.0 branch July 10, 2024 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rebase: Bump github.com/container-storage-interface/spec from 1.9.0 to 1.10.0 #4705

rebase: Bump github.com/container-storage-interface/spec from 1.9.0 to 1.10.0 #4705

dependabot bot commented on behalf of github Jul 8, 2024

iPraveenParihar commented Jul 10, 2024

nixpanic commented Jul 10, 2024

mergify bot commented Jul 10, 2024

nixpanic commented Jul 10, 2024

mergify bot commented Jul 10, 2024 •

edited

Loading

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

nixpanic commented Jul 10, 2024

nixpanic commented Jul 10, 2024

nixpanic commented Jul 10, 2024

mergify bot commented Jul 10, 2024

rebase: Bump github.com/container-storage-interface/spec from 1.9.0 to 1.10.0 #4705

rebase: Bump github.com/container-storage-interface/spec from 1.9.0 to 1.10.0 #4705

Conversation

dependabot bot commented on behalf of github Jul 8, 2024

v1.10.0

What's Changed

Breaking changes/Deprecations

Additions

Clarifications/Corrections/Fixes

Dependencies

New Contributors

v1.10.0-rc1

iPraveenParihar commented Jul 10, 2024

nixpanic commented Jul 10, 2024

mergify bot commented Jul 10, 2024

✅ Branch has been successfully rebased

nixpanic commented Jul 10, 2024

mergify bot commented Jul 10, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

ceph-csi-bot commented Jul 10, 2024

nixpanic commented Jul 10, 2024

nixpanic commented Jul 10, 2024

nixpanic commented Jul 10, 2024

mergify bot commented Jul 10, 2024

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot commented Jul 10, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`