Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Slack invite link on the README #4621

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix the Slack invite link on the README #4621

merged 1 commit into from
May 22, 2024

Conversation

tullis
Copy link
Contributor

@tullis tullis commented May 16, 2024

The link on the README file to get an invite to the Ceph Slack was missing a URL scheme, so it was interpreted as a relative link and resulted in a 404.

Describe what this PR does

Adds the URL scheme of https:// to the link to the Slack invite.

Is there anything that requires special attention

No

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release. n/a
  • Documentation has been updated, if necessary. n/a
  • Unit tests have been added, if necessary. n/a
  • Integration tests have been added, if necessary. n/a

@Rakshith-R
Copy link
Contributor

@tullis
Thanks for the pr!

Can you please prefix your commit message with doc: ?

@tullis tullis force-pushed the fix_slack_invite_link branch from 923f90c to 7abf716 Compare May 16, 2024 15:41
@iPraveenParihar
Copy link
Contributor

@tullis, Can you add the sign-off to your commit?
you can do it by git commit --amend -s and do force push

@iPraveenParihar iPraveenParihar added the component/docs Issues and PRs related to documentation label May 17, 2024
@tullis tullis force-pushed the fix_slack_invite_link branch from 7abf716 to f66024d Compare May 21, 2024 12:02
@Rakshith-R
Copy link
Contributor

@Mergifyio rebase

@tullis @Rakshith-R
doc: Fix the Slack invite link
2e747b7 
The link on the README file to get an invite to the Ceph Slack was
missing a URL scheme, so it was interpreted as a relative link and
resulted in a 404.

Signed-off-by: Ben Tullis <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

rebase

✅ Branch has been successfully rebased

@Rakshith-R Rakshith-R force-pushed the fix_slack_invite_link branch from f66024d to 2e747b7 Compare May 22, 2024 05:57
Rakshith-R
Rakshith-R approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rakshith-R Rakshith-R requested review from iPraveenParihar and a team May 22, 2024 06:00
@iPraveenParihar iPraveenParihar added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels May 22, 2024
@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8f7a4c4

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label May 22, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label May 22, 2024
@mergify mergify bot merged commit 8f7a4c4 into ceph:devel May 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tullis @Rakshith-R @iPraveenParihar @ceph-csi-bot