rbd: add ParentInTrash parameter in rbdImage struct (backport #4522) #4579
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This commit adds ParentInTrash parameter in rbdImage struct and makes use of it in getParent() function in order to avoid error in case the parent is present but in trash. Signed-off-by: Rakshith R <[email protected]> (cherry picked from commit c34b31e)
This commit modifies a test case to check creation of PVC-PVC clone of a restored PVC when parent snapshot is deleted. Signed-off-by: Rakshith R <[email protected]> (cherry picked from commit 1bb78fd)
mergify
bot
added
ok-to-test
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
@Mergifyio refresh |
✅ Pull request refreshed |
nixpanic
added
the
ready-to-merge
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio rebase |
✅ Nothing to do for rebase action |
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
I fail to see why this rule is not sufficient: Possibly this is because ci/centos/k8s-e2e-external-storage/1.26 failed, but that one should not be required 🤔 |
|
this says it required 1.26 |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio dequeue |
☑️ The pull request is not queued |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
rbd: add ParentInTrash parameter in rbdImage struct
This commit adds ParentInTrash parameter in rbdImage struct
and makes use of it in getParent() function in order to avoid
error in case the parent is present but in trash.
This commit modifies a test case to check creation of PVC-PVC clone of a restored PVC when parent snapshot is deleted.
Signed-off-by: Rakshith R [email protected]
Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
This is an automatic backport of pull request #4522 done by [Mergify](https://mergify.com).