Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: make fsName as optional for static PVC #4372

Merged
merged 3 commits into from
Jan 12, 2024
Merged

cephfs: make fsName as optional for static PVC #4372

merged 3 commits into from
Jan 12, 2024

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Jan 12, 2024

consider fsName optional for static volume as it is not required to be set during mount operation with fuse and kernel client.

fixes: #4311

@Madhu-1
cephfs: make fsname as optional for static PVC
7318034 
consider fsName optional for static volume
as it is not required to be set during mount
operation with fuse and kernel client.

fixes: ceph#4311

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
e2e: add e2e to test static pvc
c0577a1 
added e2e test case to verify static
pvc with and without fsName in the PV
object.

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify mergify bot added the component/cephfs Issues related to CephFS label Jan 12, 2024
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 12, 2024

/test ci/centos/mini-e2e/k8s-1.27//test_type-cephfs

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 12, 2024

/test ci/centos/mini-e2e/k8s-1.27/test_type-cephfs

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 12, 2024

/test ci/centos/mini-e2e/k8s-1.27

@Madhu-1 Madhu-1 mentioned this pull request Jan 12, 2024
Closed
@Madhu-1 Madhu-1 added the WIP This PR still in work-in-progress label Jan 12, 2024
@Madhu-1
doc: fix fsName details in PV object
830ae5c 
fsName is optional and its required
to mount the filesystem incase if we have
multiple filesystem in the cluster.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1 Madhu-1 removed the WIP This PR still in work-in-progress label Jan 12, 2024
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 12, 2024

With FsName in PV object

I0112 08:43:32.364078       1 utils.go:195] ID: 42 Req-ID: cephfs-static-pv GRPC call: /csi.v1.Node/NodeStageVolume
I0112 08:43:32.364163       1 utils.go:206] ID: 42 Req-ID: cephfs-static-pv GRPC request: {"secrets":"***stripped***","staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8d9158f5e461066ad0b7f7b9a82af1beae35f4123c00c513663e7c9dace6d526/globalmount","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":5}},"volume_context":{"clusterID":"rook-ceph","fsName":"myfs","rootPath":"/volumes/csi/test/85f345be-1ab6-4986-99f5-60bd93debdd8","staticVolume":"true"},"volume_id":"cephfs-static-pv"}
I0112 08:43:32.364292       1 volumemounter.go:126] requested mounter: , chosen mounter: kernel
I0112 08:43:32.364352       1 nodeserver.go:301] ID: 42 Req-ID: cephfs-static-pv cephfs: mounting volume cephfs-static-pv with Ceph kernel client
I0112 08:43:32.373602       1 cephcmds.go:105] ID: 42 Req-ID: cephfs-static-pv command succeeded: modprobe [ceph]
I0112 08:43:32.470747       1 cephcmds.go:105] ID: 42 Req-ID: cephfs-static-pv command succeeded: mount [-t ceph 10.110.155.120:6789:/volumes/csi/test/85f345be-1ab6-4986-99f5-60bd93debdd8 /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8d9158f5e461066ad0b7f7b9a82af1beae35f4123c00c513663e7c9dace6d526/globalmount -o name=csi-cephfs-node,secretfile=/tmp/csi/keys/keyfile-897971711,mds_namespace=myfs,_netdev]
I0112 08:43:32.470801       1 nodeserver.go:253] ID: 42 Req-ID: cephfs-static-pv cephfs: successfully mounted volume cephfs-static-pv to /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8d9158f5e461066ad0b7f7b9a82af1beae35f4123c00c513663e7c9dace6d526/globalmount

Without FsName in PV object

I0112 09:03:05.949380       1 utils.go:164] ID: 6 Req-ID: cephfs-static-pv GRPC call: /csi.v1.Node/NodeStageVolume
I0112 09:03:05.949587       1 utils.go:165] ID: 6 Req-ID: cephfs-static-pv GRPC request: {"secrets":"***stripped***","staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8d9158f5e461066ad0b7f7b9a82af1beae35f4123c00c513663e7c9dace6d526/globalmount","volume_capability":{"AccessType":{"Mount":{}},"access_mode":{"mode":5}},"volume_context":{"clusterID":"rook-ceph","rootPath":"/volumes/csi/test/85f345be-1ab6-4986-99f5-60bd93debdd8","staticVolume":"true"},"volume_id":"cephfs-static-pv"}
I0112 09:03:05.949787       1 volumemounter.go:126] requested mounter: , chosen mounter: kernel
I0112 09:03:05.949856       1 nodeserver.go:312] ID: 6 Req-ID: cephfs-static-pv cephfs: mounting volume cephfs-static-pv with Ceph kernel client
I0112 09:03:05.954739       1 cephcmds.go:105] ID: 6 Req-ID: cephfs-static-pv command succeeded: modprobe [ceph]
I0112 09:03:06.037884       1 cephcmds.go:105] ID: 6 Req-ID: cephfs-static-pv command succeeded: mount [-t ceph 10.110.155.120:6789:/volumes/csi/test/85f345be-1ab6-4986-99f5-60bd93debdd8 /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8d9158f5e461066ad0b7f7b9a82af1beae35f4123c00c513663e7c9dace6d526/globalmount -o name=csi-cephfs-node,secretfile=/tmp/csi/keys/keyfile-1940266435,_netdev]
I0112 09:03:06.037951       1 nodeserver.go:252] ID: 6 Req-ID: cephfs-static-pv cephfs: successfully mounted volume cephfs-static-pv to /var/lib/kubelet/plugins/kubernetes.io/csi/rook-ceph.cephfs.csi.ceph.com/8d9158f5e461066ad0b7f7b9a82af1beae35f4123c00c513663e7c9dace6d526/globalmount

@Madhu-1 Madhu-1 requested review from a team January 12, 2024 09:13
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 12, 2024

/test ci/centos/mini-e2e/k8s-1.27

@Madhu-1 Madhu-1 added the ok-to-test Label to trigger E2E tests label Jan 12, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jan 12, 2024
@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e/k8s-1.26

@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e/k8s-1.26

Failed with a spurious Ceph error:

  [FAILED] failed to validate rbd images in pool replicapool trash: failed to list images in trash 2024-01-12T16:33:22.807+0000 7f81594e7700 -1 monclient: handle_auth_reply_more no authorizer?

@mergify mergify bot merged commit 200fbdb into ceph:devel Jan 12, 2024
25 checks passed
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Feb 1, 2024

@Mergifyio backport release-v3.10

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024 •
edited
Loading

backport release-v3.10

✅ Backports have been created

@mergify mergify bot mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@yati1998 yati1998 yati1998 approved these changes

Assignees
No one assigned
Labels
component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mount static cephFS pvc via fuse inside Kubernetes pod with fsName=""
4 participants
@Madhu-1 @ceph-csi-bot @nixpanic @yati1998