Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: bump the golang-dependencies group with 1 update #4323

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps the golang-dependencies group with 1 update: golang.org/x/crypto.

Updates golang.org/x/crypto from 0.16.0 to 0.17.0

Commits
  • 9d2ee97 ssh: implement strict KEX protocol changes
  • 4e5a261 ssh: close net.Conn on all NewServerConn errors
  • 152cdb1 x509roots/fallback: update bundle
  • fdfe1f8 ssh: defer channel window adjustment
  • b8ffc16 blake2b: drop Go 1.6, Go 1.8 compatibility
  • 7e6fbd8 ssh: wrap errors from client handshake
  • bda2f3f argon2: avoid clobbering BP
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Depends-on: #4332


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the rebase update the version of an external component label Dec 18, 2023
dependabot bot and others added 2 commits December 20, 2023 10:41
Bumps the golang-dependencies group with 1 update: [golang.org/x/crypto](https://github.com/golang/crypto).


Updates `golang.org/x/crypto` from 0.16.0 to 0.17.0
- [Commits](golang/crypto@v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Some packages still have issues because older Go versions fail to tidy
go.mod because some modules require go 1.21. `go mod tidy` has now been
run with go 1.21.5, so everything is clean again.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic force-pushed the dependabot/go_modules/golang-dependencies-c775a3108c branch from c3e0606 to 29f0a99 Compare December 20, 2023 09:52
nixpanic
nixpanic previously approved these changes Dec 20, 2023
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Dec 20, 2023
@nixpanic nixpanic requested a review from a team December 20, 2023 09:55
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 20, 2023
Rakshith-R
Rakshith-R previously approved these changes Dec 20, 2023
@mergify mergify bot dismissed stale reviews from Rakshith-R and nixpanic December 20, 2023 12:25

Pull request has been modified.

nixpanic
nixpanic previously approved these changes Dec 20, 2023
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Dec 20, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@nixpanic nixpanic requested a review from Rakshith-R December 20, 2023 18:28
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Dec 20, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 20, 2023
@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e-helm/k8s-1.26

@nixpanic
Copy link
Member

CI fails because it uses an old :devel image, and not an updated one that includes the changes of this PR. Splitting some changes into #4341 in the hope that can pass CI.

@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e-helm/k8s-1.28

@nixpanic
Copy link
Member

/test ci/centos/upgrade-tests

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-helm/k8s-1.27

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-helm/k8s-1.26

@nixpanic
Copy link
Member

dependency-review fails, but is not blocking merging. The dependency update can be found in #4330

@nixpanic nixpanic requested a review from a team December 21, 2023 10:21
mergify bot added a commit that referenced this pull request Dec 21, 2023
@nixpanic
Copy link
Member

😢 it seems something was merged after this was rebased, and now CI needs to run again.

@mergify mergify bot merged commit 35f034f into devel Dec 21, 2023
@mergify mergify bot deleted the dependabot/go_modules/golang-dependencies-c775a3108c branch December 21, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebase update the version of an external component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants