fix: configuring cephfs snapshots and clones #3742
Conversation
examples/README.md
Outdated
| To be sure everything is OK you can run `cephfs snap ls [your-pvc-name]` inside | ||
| one of your Ceph pod. |
There was a problem hiding this comment.
This is not correct, please check again.
| To restore the snapshot to a new PVC, deploy | ||
| [pvc-restore.yaml](./cephfs/pvc-restore.yaml) and a testing pod | ||
| [pod-restore.yaml](./cephfs/pod-restore.yaml): | ||
|
|
||
| ```bash | ||
| kubectl create -f pvc-restore.yaml | ||
| kubectl create -f pod-restore.yaml | ||
| ``` |
There was a problem hiding this comment.
Provide a cleanup step as well.
examples/README.md
Outdated
| [snapshotclass.yaml](./cephfs/snapshotclass.yaml) and | ||
| [snapshot.yaml](./cephfs/snapshot.yaml). | ||
|
|
||
| Once you created your Cephfs volume, you'll need to customize at least |
examples/README.md
Outdated
| [snapshot.yaml](./cephfs/snapshot.yaml). | ||
|
|
||
| Once you created your Cephfs volume, you'll need to customize at least | ||
| `snapshotclass.yaml` and make sure the `clusterId` parameter matches |
There was a problem hiding this comment.
clusterId should be clusterID?
examples/README.md
Outdated
| NAME AGE | ||
| cephfs-pvc-snapshot 6s |
There was a problem hiding this comment.
i think it will show more output can you please check?
| $ kubectl get pvc | ||
| NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE | ||
| csi-cephfs-pvc Bound pvc-1ea51547-a88b-4ab0-8b4a-812caeaf025d 1Gi RWX csi-cephfs-sc 20h | ||
| cephfs-pvc-clone Bound pvc-b575bc35-d521-4c41-b4f9-1d733cd28fdf 1Gi RWX csi-cephfs-sc 39s |
There was a problem hiding this comment.
provide cleanup step at last?
examples/README.md
Outdated
| @@ -296,3 +296,76 @@ Units: sectors of 1 * 512 = 512 bytes | |||
| Sector size (logical/physical): 512 bytes / 512 bytes | |||
| I/O size (minimum/optimal): 4194304 bytes / 4194304 bytes | |||
| ``` | |||
| ### How to create Cephfs Snapshots | |||
There was a problem hiding this comment.
Cephfs to CephFS, you are also talking about restore and PVC clone can you reword this one?
There was a problem hiding this comment.
For clone. provided a separate heading.
examples/README.md
Outdated
| Before continuing, make sure you enabled the required | ||
| feature gate `VolumeSnapshotDataSource=true` in your Kubernetes cluster. |
There was a problem hiding this comment.
This is no more required on the supported kubernetes version and we can skip it?
|
Thanks for the review @Madhu-1, updated the PR with suggested changes. |
|
@Rakshith-R Could you please review. |
|
@Mergifyio rebase |
this commit updates the readme with the instructions on how to configure snapshots and clones of cephfs pvc Signed-off-by: riya-singhal31 <[email protected]>
✅ Branch has been successfully rebased |
Madhu-1
added
component/docs
|
/test ci/centos/k8s-e2e-external-storage/1.23 |
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.23 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.23 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
this commit updates the readme with the instructions on how to configure snapshots and clones of cephfs pvc.
Fixes: #3691