ci: add support for VM_DRIVER=podman to scripts/minikube.sh #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests can be restarted once #3419 is merged. That PR may even re-enable the CI jobs automatically. |
nixpanic
force-pushed
the
minikube/podman
branch
from
4482f98 to
dfe1144
Compare
nixpanic
changed the title
nixpanic
added
backport-to-release-v3.7
ci/skip/multi-arch-build
Rakshith-R
previously approved these changes
Oct 10, 2022
Madhu-1
previously approved these changes
Oct 10, 2022
|
/test ci/centos/k8s-e2e-external-storage/1.22 |
nixpanic
force-pushed
the
minikube/podman
branch
from
dfe1144 to
ac65c7f
Compare
mergify
bot
dismissed stale reviews from Madhu-1 and Rakshith-R
Pull request has been modified.
Madhu-1
reviewed
Oct 12, 2022
Madhu-1
reviewed
Oct 12, 2022
nixpanic
commented
Oct 12, 2022
nixpanic
force-pushed
the
minikube/podman
branch
from
ac65c7f to
477606c
Compare
nixpanic
commented
Oct 12, 2022
nixpanic
force-pushed
the
minikube/podman
branch
from
477606c to
cf93ba0
Compare
Madhu-1
previously approved these changes
Oct 12, 2022
Rakshith-R
previously approved these changes
Oct 12, 2022
|
/retest ci/centos/mini-e2e/k8s-1.24 |
mergify
bot
dismissed stale reviews from Rakshith-R and Madhu-1
Pull request has been modified.
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <[email protected]>
The scale down/up functions fail often with "deployment not found" errors. Possibly deploying with Podman is slower than deploying in a minikube VM, and there is a delay for the deployment to become available. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
minikube/podman
branch
from
8785652 to
41df719
Compare
In case `wget` is not installed, downloading the Helm release will fail. The `install-helm.sh` script won't return a fatal error in that case, and CI jobs continue running in an environment that is not ready. By adding a check that exist the script with a failure, the CI will now correctly report a problem when Helm can not be downloaded. See-also: ceph#3430 Signed-off-by: Niels de Vos <[email protected]>
|
/retest ci/centos/mini-e2e-helm/k8s-1.24 |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
There are occasions where deleting a PVC (or PV) never succeeds. The reported status of the deleted object is sometimes empty, which suggests that the PVC or PV was, in fact, deleted. To diagnose the incorrect error checking, include the errors for retrying in the logs. Signed-off-by: Niels de Vos <[email protected]>
Because the rbd-nbd tests fail with minikube and the Podman driver, disable the tests for the time being. Updates: ceph#3431 Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
minikube/podman
branch
from
be6765c to
29b0aca
Compare
Madhu-1
reviewed
Oct 13, 2022
Comment on lines
+287
to
+292
| e2elog.Logf("PVC %s (status: %s) has not been deleted yet, rechecking...", name, pvc.Status) | ||
|
|
||
| return false, nil | ||
| } | ||
| if isRetryableAPIError(err) { | ||
| e2elog.Logf("failed to verify deletion of PVC %s (status: %s): %v", name, pvc.Status, err) |
There was a problem hiding this comment.
logging pvc name along with namespace name helps
There was a problem hiding this comment.
that is included in already existing logs at the start of this sub-function
| if !testNBD { | ||
| e2elog.Logf("skipping NBD test") | ||
|
|
||
| return |
There was a problem hiding this comment.
return will skip all the tests or only this test?
There was a problem hiding this comment.
It returns from the current function, so it should continue with the next test. The Skip() functions cause a more complete return, so those can not be used here.
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
Failed with |
Madhu-1
approved these changes
Oct 13, 2022
Rakshith-R
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies.
Depends-on: #3419
Closes: #3415
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results