Update relative path to ceph-config.yaml file #3273
Conversation
|
Thanks @palvarez89 for the contribution 👍 . The DCO check fails due to missing |
| @@ -164,7 +164,7 @@ for more information. | |||
| **Deploy Ceph configuration ConfigMap for CSI pods:** | |||
|
|
|||
| ```bash | |||
| kubectl create -f ../example/ceph-config.yaml | |||
| kubectl create -f ../../../example/ceph-config.yaml | |||
There was a problem hiding this comment.
Can you explain in the commit message why this is needed? If the file is relative to this document, a single ../ seems sufficient.
Note that other files are referenced without a path. If this gets corrected, other references should be adapted too.
There was a problem hiding this comment.
I know is not explicit, but all the previous steps kind of assume that you are on deploy/cephfs/kubernetes folder, making the current relative path to the example folder not work.
If this reason is good enough for you, I can update the commit message.
There was a problem hiding this comment.
Sure, that's fine with me. It would be great if you can update the commit message and adjust the subject of your commit as well. I recommend doc: update relative path to ceph-config.yaml file, the doc: prefix should be valid for the commitlint check. Make sure to add your Signed-off-by as well.
There was a problem hiding this comment.
Thank you for the pointers. I hadn't noticed the CI failures yet.
nixpanic
added
component/deployment
Signed-off-by: Pedro Alvarez <[email protected]>
Describe what this PR does
I know is not explicit, but all the previous steps kind of assume that you are on
deploy/cephfs/kubernetesfolder, making the current relative path to theexamplefolder not work.