deploy: remove external-attacher sidecar from cephfs deployment #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Jun 1, 2022
humblec
changed the title
It helps if you explain the why. |
nixpanic
added
the
component/deployment
humblec
force-pushed
the
cephfs-attacher
branch
3 times, most recently
from
82e7fc4 to
d8a7fa8
Compare
Sure . Updated the details in the PR description. |
|
As mentioned here #1106 (comment) This was already attempted a couple of times #1106 (comment), Are we sure removing is not having any problem. Have we don't all required testing to make sure no problem occurs if we remove it? |
@Madhu-1 As mentioned in the reply thread #1106 (comment), it should be fine to remove .. I dont expect any issues due to the same. More or less, many CSI drivers dont use this sidecar at all as it is unwanted. so we are good 👍 |
humblec
force-pushed
the
cephfs-attacher
branch
3 times, most recently
from
b388be6 to
d894d2d
Compare
|
/retest ci/centos/mini-e2e/k8s-1.23 |
1 similar comment
|
/retest ci/centos/mini-e2e/k8s-1.23 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
|
@Madhu-1 comments are addresssed. ptal. thanks.. |
Madhu-1
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
There was no need to have a different commit for the Doc. ideally all changes should go into 1 or 2 commits.
Considering all the tests done as per #3149 (comment) to make sure we don't need an attacher anymore approving the PR.
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
@Mergifyio refresh |
✅ Pull request refreshed |
humblec
added a commit
to humblec/ceph-csi
that referenced
this pull request
Jun 24, 2022
previously, it was a requirement to have attacher sidecar for CSI drivers and there had an implementation of dummy mode of operation. However skipAttach implementation has been stabilized and the dummy mode of operation is going to be removed from the external-attacher. Considering this driver work on volumeattachment objects for NBD driver use cases, we have to implement dummy controllerpublish and unpublish and thus keep supporting our operations even in absence of dummy mode of operation in the sidecar. This commit make a NOOP controller publish and unpublish for RBD driver. CephFS driver does not require attacher and it has already been made free from the attachment operations. Ref# ceph#3149 Ref# kubernetes-csi/external-attacher#226 Signed-off-by: Humble Chirammal <[email protected]>
humblec
added a commit
to humblec/ceph-csi
that referenced
this pull request
Jul 20, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# ceph#3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
humblec
added a commit
to humblec/ceph-csi
that referenced
this pull request
Jul 20, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# ceph#3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
humblec
added a commit
to humblec/ceph-csi
that referenced
this pull request
Jul 20, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# ceph#3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
humblec
added a commit
to humblec/ceph-csi
that referenced
this pull request
Jul 20, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# ceph#3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
humblec
added a commit
to humblec/ceph-csi
that referenced
this pull request
Jul 21, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# ceph#3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
yati1998
added a commit
to yati1998/rook
that referenced
this pull request
Aug 2, 2022
CephFS CSI driver dont have/advertise controller publish/unpublish capabilities, thus dont need attacher sidecar for its operations. The presence of external-attacher adds on overhead and issues wrt attachment in various scenarios. One of them would be the lack of performance on syncing volumeattachment from api server..etc. More or less we don't have controller publish and unpublish capabilities, so we should not make use of this sidecar and cause unnecessary addon here thus other issues. similar changes have been added to CSI ceph/ceph-csi#3149 Signed-off-by: yati1998 <[email protected]>
yati1998
added a commit
to yati1998/rook
that referenced
this pull request
Aug 2, 2022
CephFS CSI driver dont have/advertise controller publish/unpublish capabilities, thus dont need attacher sidecar for its operations. The presence of external-attacher adds on overhead and issues wrt attachment in various scenarios. One of them would be the lack of performance on syncing volumeattachment from api server..etc. More or less we don't have controller publish and unpublish capabilities, so we should not make use of this sidecar and cause unnecessary addon here thus other issues. similar changes have been added to CSI ceph/ceph-csi#3149 Signed-off-by: yati1998 <[email protected]>
humblec
added a commit
to humblec/ceph-csi
that referenced
this pull request
Aug 2, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# ceph#3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# #3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
yati1998
added a commit
to yati1998/rook
that referenced
this pull request
Aug 3, 2022
CephFS CSI driver dont have/advertise controller publish/unpublish capabilities, thus dont need attacher sidecar for its operations. The presence of external-attacher adds on overhead and issues wrt attachment in various scenarios. One of them would be the lack of performance on syncing volumeattachment from api server..etc. More or less we don't have controller publish and unpublish capabilities, so we should not make use of this sidecar and cause unnecessary addon here thus other issues. similar changes have been added to CSI ceph/ceph-csi#3149 Signed-off-by: yati1998 <[email protected]>
yati1998
added a commit
to yati1998/rook
that referenced
this pull request
Aug 3, 2022
CephFS CSI driver dont have/advertise controller publish/unpublish capabilities, thus dont need attacher sidecar for its operations. The presence of external-attacher adds on overhead and issues wrt attachment in various scenarios. One of them would be the lack of performance on syncing volumeattachment from api server..etc. More or less we don't have controller publish and unpublish capabilities, so we should not make use of this sidecar and cause unnecessary addon here thus other issues. similar changes have been added to CSI ceph/ceph-csi#3149 Signed-off-by: yati1998 <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/ceph-csi
that referenced
this pull request
Aug 4, 2022
previously, it was a requirement to have attacher sidecar for CSI
drivers and there had an implementation of dummy mode of operation.
However skipAttach implementation has been stabilized and the dummy
mode of operation is going to be removed from the external-attacher.
Considering this driver work on volumeattachment objects for NBD driver
use cases, we have to implement dummy controllerpublish and unpublish
and thus keep supporting our operations even in absence of dummy mode
of operation in the sidecar.
This commit make a NOOP controller publish and unpublish for RBD driver.
CephFS driver does not require attacher and it has already been made free
from the attachment operations.
Ref# ceph#3149
Ref# kubernetes-csi/external-attacher#226
Signed-off-by: Humble Chirammal <[email protected]>
galexrt
pushed a commit
to koor-tech/koor
that referenced
this pull request
Aug 12, 2022
CephFS CSI driver dont have/advertise controller publish/unpublish capabilities, thus dont need attacher sidecar for its operations. The presence of external-attacher adds on overhead and issues wrt attachment in various scenarios. One of them would be the lack of performance on syncing volumeattachment from api server..etc. More or less we don't have controller publish and unpublish capabilities, so we should not make use of this sidecar and cause unnecessary addon here thus other issues. similar changes have been added to CSI ceph/ceph-csi#3149 Signed-off-by: yati1998 <[email protected]>
|
I'm running a k8s 1.24 cluster and I've got a few static CephFS filesystems for which I have created static PVs and PVCs manually and use the PVCs to mount CephFS to pods. After updating to 3.7.0 new pods just get stuck with an event I don't get how things are supposed to work now. Why doesn't the CephFS PV get attached? |
|
@thrashwerk can you please open a new issue? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CephFS CSI driver dont have/advertise controller publish/unpublish capabilities, thus dont need attacher sidecar for its operations.
Also this removal take care of the burden on unncessary operation (round-trip) in the preparation of a volume for a container, and requires CSI Drivers to deploy an unnecessary sidecar container (external-attacher).
Things covered in this PR
attachRequired:falseparam as attachment is no longer required.Signed-off-by: Humble Chirammal [email protected]