rbd: Enable featuregates for volume expansion recovery #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkalever
reviewed
May 5, 2022
humblec
force-pushed
the
handle
branch
6 times, most recently
from
8ef271e to
60be4a3
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
humblec
force-pushed
the
handle
branch
2 times, most recently
from
8540f32 to
cc690f0
Compare
humblec
changed the title
it could be anything, more or less, this is a fallback mechanism for the user to come back from an error scenario. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Madhu-1
requested changes
May 23, 2022
humblec
force-pushed
the
handle
branch
2 times, most recently
from
0e19a11 to
2ac5baa
Compare
|
@Madhu-1 comments addressed, ptal. thanks. |
|
@Madhu-1 ptal. comments are addressed |
Madhu-1
approved these changes
May 25, 2022
Rakshith-R
approved these changes
May 25, 2022
The enabled feature gates helps us to recover from volume expansion failure. Signed-off-by: Humble Chirammal <[email protected]>
This commit enable the mentioned feature gate which helps to recover from volume expansion failures. Signed-off-by: Humble Chirammal <[email protected]>
this commit enable RecoverVolumeExpansionFailure featuregate in minikube deployment. Signed-off-by: Humble Chirammal <[email protected]>
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enabled feature gate helps us to recover from volume expansion
failure.
Additional Reference#
Reference below URL for this feature gate details:
https://github.com/kubernetes-csi/external-resizer/
Additional Note for reviewer:
No E2E as its a generic one and not specific to the Ceph CSI driver as like
AnnotateFSResize.Signed-off-by: Humble Chirammal [email protected]