rbd: Implement FenceClusterNetwork and UnfenceClusterNetwork #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuggupta27
changed the title
Madhu-1
reviewed
Dec 22, 2021
humblec
reviewed
Dec 22, 2021
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
|
/retest ci/centos/mini-e2e/k8s-1.22 |
|
Tested the |
Madhu-1
reviewed
Jan 4, 2022
Yuggupta27
force-pushed
the
fencing
branch
2 times, most recently
from
a84448a to
17b9b66
Compare
Madhu-1
previously approved these changes
Jan 4, 2022
| } | ||
|
|
||
| _, err := controller.FenceClusterNetwork(context.TODO(), req) | ||
| assert.Error(t, err) |
There was a problem hiding this comment.
unit tests should test for the specific error message in most of the cases to make sure things are working as expected.
humblec
reviewed
Jan 4, 2022
nixpanic
requested changes
Jan 4, 2022
Yuggupta27
force-pushed
the
fencing
branch
2 times, most recently
from
aa4af09 to
03308d5
Compare
nixpanic
previously approved these changes
Jan 6, 2022
humblec
reviewed
Jan 6, 2022
humblec
dismissed
their stale review
there are few more comments from my side, ptal..
|
/retest ci/centos/mini-e2e/k8s-1.22 |
Madhu-1
approved these changes
Jan 7, 2022
nixpanic
approved these changes
Jan 7, 2022
Signed-off-by: Yug Gupta <[email protected]>
Signed-off-by: Yug Gupta <[email protected]>
Convert the CIDR block into a range of IPs, and then add network fencing via "ceph osd blocklist" for each IP in that range. Signed-off-by: Yug Gupta <[email protected]>
Signed-off-by: Yug Gupta <[email protected]>
implement FenceClusterNetwork grpc call which allows to blocks access to a CIDR block by creating a network fence. Signed-off-by: Yug Gupta <[email protected]>
implement UnfenceClusterNetwork grpc call which allows to unblock the access to a CIDR block by removing it from network fence. Signed-off-by: Yug Gupta <[email protected]>
Signed-off-by: Yug Gupta <[email protected]>
Signed-off-by: Yug Gupta <[email protected]>
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
humblec
approved these changes
Jan 7, 2022
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation for
FenceClusterNetworkandUnfenceClusterNetworkgrpc calls.FenceClusterNetwork: allows to blocks access to a CIDR block bycreating a network fence using blocklisting.
UnfenceClusterNetwork: allows unblocking the access to aCIDR block by removing it from the network fence.
Since the controller is not available yet, e2e will be added later.
Currently, all the grpcs have been manually tested and verified.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results