Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the clone and the snapshot if Expand/DeleteSnapshot fails. #4218

Closed
iPraveenParihar opened this issue Oct 30, 2023 · 0 comments · Fixed by #4223
Closed

Remove the clone and the snapshot if Expand/DeleteSnapshot fails. #4218

iPraveenParihar opened this issue Oct 30, 2023 · 0 comments · Fixed by #4223

Comments

@iPraveenParihar
Copy link
Contributor 

          Not related to this PR, if the Expand fails or the DeleteSnapshot fails we also need to remove the clone and the snapshot, which is missing, can you please address that as well?

Originally posted by @Madhu-1 in #4202 (comment)
@iPraveenParihar iPraveenParihar mentioned this issue Oct 30, 2023
Merged
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Nov 2, 2023
@Madhu-1
cephfs: remove subvolume during clone
a5a2e54 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to aviod
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Nov 2, 2023
@Madhu-1
cephfs: remove subvolume during clone
6d16be2 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to aviod
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Nov 2, 2023
@Madhu-1
cephfs: remove subvolume during clone
5a4f3e1 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1 Madhu-1 mentioned this issue Nov 2, 2023
Merged
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Nov 2, 2023
@Madhu-1
cephfs: remove subvolume during clone
72a4e46 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <[email protected]>
nixpanic pushed a commit to Madhu-1/ceph-csi that referenced this issue Nov 3, 2023
@Madhu-1 @nixpanic
cephfs: remove subvolume during clone
35a61fe 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Nov 6, 2023
@Madhu-1
cephfs: remove subvolume during clone
4cbec35 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Nov 8, 2023
@Madhu-1
cephfs: remove subvolume during clone
58feb6f 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify mergify bot closed this as completed in #4223 Nov 8, 2023
mergify bot pushed a commit that referenced this issue Nov 8, 2023
@Madhu-1 @mergify
cephfs: remove subvolume during clone
c25f572 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: #4218

Signed-off-by: Madhu Rajanna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cephfs: remove subvolume during clone Madhu-1/ceph-csi
1 participant
@iPraveenParihar