Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CephFS PVC creation fails provision for few sizes #4179

Closed
karthik-us opened this issue Oct 10, 2023 · 1 comment · Fixed by #4180
Closed

CephFS PVC creation fails provision for few sizes #4179

karthik-us opened this issue Oct 10, 2023 · 1 comment · Fixed by #4180
Assignees
@karthik-us
Labels
bug Something isn't working component/cephfs Issues related to CephFS

Comments

@karthik-us
Copy link
Collaborator

Describe the bug

When provisioning the CephFS PVC, for some sizes it would fail to provision volumes with the expected size. For example 101M, 500M, 504M etc.

Steps to reproduce

  1. Deploy CephFS plugin
  2. Create a storage class
  3. Create a PVC with size 500M

Actual results

$ kubectl get pvc
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE
csi-cephfs-pvc Bound pvc-449021d8-d94f-49f8-bf18-d11c16bd25c1 1Gi RWX csi-cephfs-sc 3h7m
csi-cephfs-pvc-500 Pending csi-cephfs-sc 2s

Expected behavior

PVC creation should succeed and get bound to a PV.

Logs

I1009 18:13:43.980418 1 controller.go:1366] provision "default/csi-cephfs-pvc-500" class "csi-cephfs-sc": started
I1009 18:13:43.980519 1 event.go:298] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"default", Name:"csi-cephfs-pvc-500", UID:"e8111a6b-c658-4405-bc06-c7419a2ee5be", APIVersion:"v1", ResourceVersion:"18754", FieldPath:""}): type: 'Normal' reason: 'Provisioning' External provisioner is provisioning volume for claim "default/csi-cephfs-pvc-500"
W1009 18:13:44.061025 1 controller.go:934] Retrying syncing claim "e8111a6b-c658-4405-bc06-c7419a2ee5be", failure 3
E1009 18:13:44.061051 1 controller.go:957] error syncing claim "e8111a6b-c658-4405-bc06-c7419a2ee5be": failed to provision volume with StorageClass "csi-cephfs-sc": created volume capacity 499122176 less than requested capacity 500000000
I1009 18:13:44.061123 1 event.go:298] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"default", Name:"csi-cephfs-pvc-500", UID:"e8111a6b-c658-4405-bc06-c7419a2ee5be", APIVersion:"v1", ResourceVersion:"18754", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provision volume with StorageClass "csi-cephfs-sc": created volume capacity 499122176 less than requested capacity 500000000
@karthik-us
Copy link
Collaborator Author

/assign

karthik-us added a commit to karthik-us/ceph-csi that referenced this issue Oct 10, 2023
@karthik-us
cephfs: Fix cephfs PVC sizing
f1c4a6b 
Issue:
The RoundOffCephFSVolSize() function omits the fractional
part when calculating the size for cephfs volumes, leading
to the created volume capacity to be lesser than the requested
volume capacity.

Fix:
Consider the fractional part during the size calculation so the
rounded off volume size will be greater than or equal to the
requested volume size.

Signed-off-by: karthik-us <[email protected]>
Fixes: ceph#4179
@karthik-us karthik-us mentioned this issue Oct 10, 2023
Merged
@nixpanic nixpanic added bug Something isn't working component/cephfs Issues related to CephFS labels Oct 10, 2023
karthik-us added a commit to karthik-us/ceph-csi that referenced this issue Oct 11, 2023
@karthik-us
cephfs: Fix cephfs PVC sizing
fb77375 
Issue:
The RoundOffCephFSVolSize() function omits the fractional
part when calculating the size for cephfs volumes, leading
to the created volume capacity to be lesser than the requested
volume capacity.

Fix:
Consider the fractional part during the size calculation so the
rounded off volume size will be greater than or equal to the
requested volume size.

Signed-off-by: karthik-us <[email protected]>
Fixes: ceph#4179
nixpanic pushed a commit to karthik-us/ceph-csi that referenced this issue Oct 12, 2023
@karthik-us @nixpanic
cephfs: Fix cephfs PVC sizing
5abef0f 
Issue:
The RoundOffCephFSVolSize() function omits the fractional
part when calculating the size for cephfs volumes, leading
to the created volume capacity to be lesser than the requested
volume capacity.

Fix:
Consider the fractional part during the size calculation so the
rounded off volume size will be greater than or equal to the
requested volume size.

Signed-off-by: karthik-us <[email protected]>
Fixes: ceph#4179
@mergify mergify bot closed this as completed in #4180 Oct 12, 2023
mergify bot pushed a commit that referenced this issue Oct 12, 2023
@karthik-us @mergify
cephfs: Fix cephfs PVC sizing
5a0eeb8 
Issue:
The RoundOffCephFSVolSize() function omits the fractional
part when calculating the size for cephfs volumes, leading
to the created volume capacity to be lesser than the requested
volume capacity.

Fix:
Consider the fractional part during the size calculation so the
rounded off volume size will be greater than or equal to the
requested volume size.

Signed-off-by: karthik-us <[email protected]>
Fixes: #4179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthik-us karthik-us

Labels
bug Something isn't working component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cephfs: Fix cephfs PVC sizing karthik-us/ceph-csi
2 participants
@nixpanic @karthik-us