Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated grpc metrics code #4122

Closed
Madhu-1 opened this issue Sep 13, 2023 · 2 comments · Fixed by #4225
Closed

Remove deprecated grpc metrics code #4122

Madhu-1 opened this issue Sep 13, 2023 · 2 comments · Fixed by #4225

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 13, 2023

We already deprecated the grpc metrics in cephcsi, I think now we can remove it. This will also solve the issue of port conflict when cephcsi is used with hostnetworking enabled.

Originally posted by @Madhu-1 in #881 (comment)
@humblec
Copy link
Collaborator

humblec commented Sep 13, 2023 •
edited
Loading

This PR #3543 was trying to address, however got auto closed. It can be revisited if needed.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Oct 13, 2023
@Madhu-1 Madhu-1 removed the wontfix This will not be worked on label Oct 16, 2023
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Nov 2, 2023
@Madhu-1
util: remove deprecated grpc metrics
ae4050f 
This commit removes the deprecated
grpc related code from cephcsi.

fixes: ceph#4122

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1 Madhu-1 mentioned this issue Nov 2, 2023
Merged
@mergify mergify bot closed this as completed in #4225 Nov 3, 2023
mergify bot pushed a commit that referenced this issue Nov 3, 2023
@Madhu-1 @mergify
util: remove deprecated grpc metrics
3ea540b 
This commit removes the deprecated
grpc related code from cephcsi.

fixes: #4122

Signed-off-by: Madhu Rajanna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: Remove deprecated grpc metrics code Madhu-1/ceph-csi
2 participants
@humblec @Madhu-1