add helm charts to the repo #205
Conversation
Madhu-1
force-pushed
the
add-helm-chart
branch
8 times, most recently
from
31e44aa to
4e77022
Compare
|
@subhamkrai can you please check if this is enough for helm charts integration |
deploy/chart/values.yaml
Outdated
| watchNamespace: "" | ||
| image: | ||
| repository: quay.io/cephcsi/ceph-csi-operator | ||
| tag: latest |
There was a problem hiding this comment.
We would need a version-specific tag published when a version is released.
There was a problem hiding this comment.
And how will the csi operator be versioned?
There was a problem hiding this comment.
@travisn Yes this is only for main branch, we need to adjust the script to change the tag based on the release version
There was a problem hiding this comment.
@subhamkrai i will take care of it, Currently there is no way to automate it, i have to take care of it manually before releases.
There was a problem hiding this comment.
okay, just wanted to raise here
deploy/chart/values.yaml
Outdated
| - ALL | ||
| readOnlyRootFilesystem: true | ||
| image: | ||
| repository: gcr.io/kubebuilder/kube-rbac-proxy |
There was a problem hiding this comment.
Is this just for building, or does the helm chart install the rbac proxy container? I would expect the helm chart to only install the csi operator.
There was a problem hiding this comment.
Today csi-operator container 2 containers one is rbac proxy and another is csi-operator manager, This is auto generated files(helm charts).
There was a problem hiding this comment.
having 2 commits one for auot-generated files and one for actually changes will make easier to review wdyt?
There was a problem hiding this comment.
@subhamkrai with this everything is autogenerated except makefile.
Madhu-1
force-pushed
the
add-helm-chart
branch
from
4e77022 to
6df3836
Compare
adding helmify to makefile to generate the helm charts for operator Signed-off-by: Madhu Rajanna <[email protected]>
adding github workflow to test operator helm chart Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
add-helm-chart
branch
from
6df3836 to
1566357
Compare
This changes contains the generated operator helm charts. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
add-helm-chart
branch
from
1566357 to
d98c2af
Compare
use the new helmify helm plugin to generate the helm charts for the repo
helm doc http://book.kubebuilder.io/plugins/available/helm-v1-alpha.html?highlight=helm#helm-plugin-helmv1-alpha
As above is still alpha version and missing the kustomization support and the above one is contributed based on the idea of helmify using helmify for now.