ceph-dev*: intermediate transition to WITH_CRIMSON #2329
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: ceph/ceph#61672 This PR changes any WITH_SEASTAR / --with-seastar to WITH_CRIMSON / --with crimson respectively. We should let our builders add the new flags and once the PR is merged we could clean up the unused WITH_SEASTAR. Signed-off-by: Matan Breizman <[email protected]>
14 tasks
rzarzynski
reviewed
Feb 25, 2025
| @@ -874,6 +874,7 @@ ceph_build_args_from_flavor() { | |||
| ;; | |||
| crimson) | |||
| CEPH_EXTRA_RPMBUILD_ARGS="--with seastar" | |||
| CEPH_EXTRA_RPMBUILD_ARGS="${CEPH_EXTRA_RPMBUILD_ARGS} --with crimson" | |||
There was a problem hiding this comment.
This construct looks weird / confusing. Isn't += working here?
There was a problem hiding this comment.
I tried += first but I saw already existing users here that go with this approach so I preferred keeping it that way. This should be removed once the PR mentioned is merged.
rzarzynski
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ceph/ceph#61672
This PR changes any WITH_SEASTAR / --with-seastar to WITH_CRIMSON / --with crimson respectively. We should let our builders add the new flags and once the PR is merged we could clean up the unused WITH_SEASTAR.