Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frieren_Clean_Architecture_Robert_Martin #735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RoTour
Copy link

@RoTour RoTour commented Feb 6, 2025

First contribution to an Open-source project and proud of it

@BenBE
Copy link

BenBE commented Feb 8, 2025

Interesting image :)

Could you please avoid committing dot files like .DS_Store? These should not be part of version history.

Second, and that's more of an artistic thing, IMHO, the framing might be a bit better, if only the left half of the image was kept, cropping out the (kinda blurred) horse on the right. Unless I'm missing some joke with having Frieren look at the behinds of the horse, in which case …

@RoTour
Copy link
Author

RoTour commented Feb 11, 2025

Just applied the recommended changes, let me know I there are any other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants