Remove "mint" from default features of common crates #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
mint
from the default features ofcashu
,cdk
,cdk-sqlite
andcdk-redb
.This is because these libraries, in their default state (i.e. as published to crates.io), are typically used in apps integrating the CDK Wallet. Having both
mint
andwallet
features enabled by default can lead to confusion when callers try to resolve imports, for exampleespecially since some words are ambiguous:
mint
can mean the act of minting, or the mint as the counterparty.By removing
mint
and keepingwallet
in the default feature list, this PR removes this possible source of confusion for integrating apps.Checklist
just final-check
before committing