misk-actions depends on newly created misk-action-scopes #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent PR, pulled the ActionScoped class out of the misk-actions subproject into a new misk-action-scopes subproject. This was a breaking change for any repositories having a dependency on misk-actions and using ActionScoped. cashapp#2301 This commit adds an api dependency in misk-actions to misk-action-scopes, so that the misk-actions package included the classes from that dependency.
swankjesse
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR, pulled the ActionScoped class out of the
misk-actionssubproject into a newmisk-action-scopessubproject:#2301
That was a breaking change for any repositories having a dependency on
misk-actionsand using ActionScoped or any other class moved to the new subproject.This commit adds an api dependency in
misk-actionstomisk-action-scopes, so that themisk-actionspackage includs the classes from that dependency.