Multi-method WebActions

[quad]

This seemingly arbitrary restriction forces single method service classes.

Unholy.

I suspect this restriction dates back to the original implementation of WebActionModule wherein routing checks were done inline. Those checks are now done at the WebActionsServlet … so I think this change is safe.

Perfunctory tests attached, of course.

[swankjesse]

Love it

[quad]

Good idea. I'll make a follow-up PR.

…

On Thu, Nov 4, 2021 at 9:26 PM Jesse Wilson ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In misk/src/main/kotlin/misk/web/actions/WebActionFactory.kt <#2198 (comment)>: > @@ -67,21 +67,6 @@ internal class WebActionFactory @Inject constructor( "on ${webActionClass.simpleName}" } - require(actionFunctions.size == 1) { Maybe require actionFunctions.isNotEmpty? That'd indicate a user error. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2198 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF3WN52BQK46IF6VNGIY3UKJUVRANCNFSM5HK36OLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[quad]

Ahh, I see why you deleted the comment. 😅

…

On Thu, Nov 4, 2021 at 10:22 PM Scott Robinson ***@***.***> wrote: Good idea. I'll make a follow-up PR. On Thu, Nov 4, 2021 at 9:26 PM Jesse Wilson ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In misk/src/main/kotlin/misk/web/actions/WebActionFactory.kt > <#2198 (comment)>: > > > @@ -67,21 +67,6 @@ internal class WebActionFactory @Inject constructor( > "on ${webActionClass.simpleName}" > } > > - require(actionFunctions.size == 1) { > > Maybe require actionFunctions.isNotEmpty? That'd indicate a user error. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#2198 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAF3WN52BQK46IF6VNGIY3UKJUVRANCNFSM5HK36OLQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >