Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-method WebActions #2198

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Multi-method WebActions #2198

merged 2 commits into from
Nov 4, 2021

Conversation

quad
Copy link
Collaborator

@quad quad commented Nov 4, 2021

This seemingly arbitrary restriction forces single method service classes.

Unholy.

I suspect this restriction dates back to the original implementation of WebActionModule wherein routing checks were done inline. Those checks are now done at the WebActionsServlet … so I think this change is safe.

Perfunctory tests attached, of course.

Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@quad quad merged commit ab29f41 into master Nov 4, 2021
@quad quad deleted the ssr/20211104/multi-webactions branch November 4, 2021 10:52
@quad
Copy link
Collaborator Author

quad commented Nov 4, 2021 via email

@quad
Copy link
Collaborator Author

quad commented Nov 4, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants