Skip to content

Commit

Permalink
fix: refactor database_created hook
Browse files Browse the repository at this point in the history
  • Loading branch information
nsklikas committed Apr 22, 2024
1 parent 192273a commit f231334
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def _update_workload(self, event: HookEvent) -> None:
def _on_peer_relation_changed(self, event: RelationChangedEvent) -> None:
self._update_workload(event)

@requires_state_setter
@requires_state
def _on_database_created(self, event: DatabaseCreatedEvent) -> None:
"""Database event handler."""
if not self._container.can_connect():
Expand All @@ -386,6 +386,12 @@ def _on_database_created(self, event: DatabaseCreatedEvent) -> None:
self._update_workload(event)
return

if not self.unit.is_leader():
logger.info("Unit does not have leadership")
self.unit.status = WaitingStatus("Unit waiting for leadership to run the migration")
event.defer()
return

if not self._run_sql_migration():
self.unit.status = BlockedStatus("Database migration job failed")
logger.error("Automigration job failed, please use the schema-upgrade action")
Expand Down

0 comments on commit f231334

Please sign in to comment.