Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN exception when rounding dimensions #5482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmytroKarataiev
Copy link

Description

Fixes this issue: #5356

This change:

  1. Checks if the scaled width/height values are finite (not NaN or infinite) using isFinite()
  2. If the value is finite, rounds it to an integer as before
  3. If the value is not finite (NaN or infinite), falls back to using the constraints' minimum dimensions
    This prevents any potential IllegalArgumentException that could be thrown when trying to round NaN or infinite values, making the code more robust.

Motivation and Context

Copy link

google-cla bot commented Feb 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant