Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fetcher documentation #2153

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Conversation

FrancoisBlavoet
Copy link
Contributor

The Fetcher documentation needs to be updated for the new Glide 4 API

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@FrancoisBlavoet
Copy link
Contributor Author

Unrelated : should glide use @workerthread @mainthread annotations ?
That would make its API simpler to grok

@TWiStErRob
Copy link
Collaborator

Yes, I support threading annotations, it helps a lot to know if you can do I/O and other stuff safely. All the components of the flow should be annotated. e.g. I never know if Transcoder is on UI or not. Annotations are more prevalent than the * <p> This will always be called on comments. Adding UI thread annotation on the listener/target interface will break a lot of people's builds (lint), in a good way!

@googlebot
Copy link

CLAs look good, thanks!

@sjudd
Copy link
Collaborator

sjudd commented Jul 21, 2017

Great thanks!

@sjudd sjudd merged commit 0ebc259 into bumptech:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants