-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plat-11665] New mazerunner api #1639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpotent mazerunner API
Generated by 🚫 Danger |
d56b432
to
18837b2
Compare
8e56361
to
e5489f2
Compare
ff13fa1
to
f87c6dc
Compare
[full ci]
Refresh iOS 16 and 17 e2e test strategy
twometresteve
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update this repo to use the new idempotent mazerunner API so that we can reduce the number of flakes.
Design
This follows the same approach as used in bugsnag-cocoa-performance, with the added twist that we store the most recent maze runner command UUID in
NSUserDefaults
so that the data survives app restarts (because we are deliberately crashing the app).Changes
This PR unfortunately has a huge number of changed files, but most of them are very small, repetitive changes.
configure
instead of configuring in thestartBugsnag
method. This accounts for most of the changed files. Some scenarios have been updated to become more robust to the new timing..feature
files needed to be updated for the different timing we now have, and to remove some old workarounds that are no longer relevant.macOSTestApp
andiosTestApp
saw the most big changes in order to make them use the Fixture class rather than driving things itself.eventMode
has been removed, and instead every command takes a list of arguments. For example inAppHangScenario.swift
,TimeInterval(eventMode!)!
is nowTimeInterval(args[0])!
.performBlockAndWaitForEventDelivery
has been replaced withwaitForEventDelivery:andThen
because the old approach blocked the main thread, which can cause the app to hang. Similarly forperformBlockAndWaitForSessionDelivery
FixtureConfig
.CommandReaderThread.swift
,Fixture.swift
, andMazeRunnerCommand.swift
are copied from BugsnagPerformance with a few minor changes.Testing
There is no new functionality - We're just changing the testing rig.