Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test fixture build warnings #1277

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fix test fixture build warnings #1277

merged 1 commit into from
Jan 11, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Fix build warnings when building test fixtures.

Changeset

  • Stops using deprecated Bugsnag APIs
  • Fixes warning: The file reference for "NetworkBreadcrumbsScenario.swift" is a member of multiple groups ("scenarios" and "scenarios"); this indicates a malformed project
  • Specifies build destinations to fix WARNING: Using the first of multiple matching destinations

Testing

Verified locally and on CI

@nickdowell nickdowell enabled auto-merge (squash) January 11, 2022 10:38
@nickdowell nickdowell merged commit c72c203 into next Jan 11, 2022
@nickdowell nickdowell deleted the nickdowell/fix-build-warnings branch January 11, 2022 10:38
@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,255,896 bytes

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

@kattrali kattrali Awaiting requested review from kattrali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @kstenerud