Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-7766] Enable syncing feature flags to React Native #1270

Merged
merged 2 commits into from
Jan 5, 2022
Merged

[PLAT-7766] Enable syncing feature flags to React Native #1270

merged 2 commits into from
Jan 5, 2022

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Jan 4, 2022 •
edited
Loading

Goal

Allow Bugsnag's React Native layer to observe changes to feature flags made via the Cocoa API.

Changeset

  • Replaces BugsnagStateEvent with a simpler mechanism to reduce code size, coupling between notifiers (the type names and property names were intepreted directly in the React Native layer) and overhead when used without RN.
  • Adds callback events for addition and removal of feature flags.

Testing

  • Covered by unit tests in this repo
  • Covered by E2E tests in the React Native repo - sample run

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size decreased by 2,424 bytes from 1,300,512 to 1,298,088 🎉

Generated by 🚫 Danger

@nickdowell nickdowell mentioned this pull request Jan 4, 2022
Merged
kattrali
kattrali approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much, much simpler

@nickdowell nickdowell merged commit 6d7f9cf into integration/feature-flags Jan 5, 2022
@nickdowell nickdowell deleted the nickdowell/feature-flags-rn-sync branch January 5, 2022 13:56
@nickdowell nickdowell mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

@kstenerud kstenerud Awaiting requested review from kstenerud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @kattrali