Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase iOS E2E timeout to 60 minutes #1146

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Increase iOS E2E timeout to 60 minutes #1146

merged 1 commit into from
Jul 6, 2021

Conversation

nickdowell
Copy link
Contributor

Increases the timeout on the iOS E2E tests because recently we have seen failures due to reaching the 45 minute limit.

@nickdowell nickdowell requested a review from twometresteve July 6, 2021 07:57
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,134,024 bytes

Generated by 🚫 Danger

twometresteve
twometresteve approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I think makes sense overall, but I'll also do some investigation to try and work out where the slowdown has come from.

@nickdowell nickdowell merged commit 287ca87 into next Jul 6, 2021
@nickdowell nickdowell deleted the nickdowell/e2e-timeouts branch July 6, 2021 08:24
@nickdowell nickdowell mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @twometresteve