Fix test flake in features/session_stopping.feature:21 #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix an E2E test flake in
features/session_stopping.feature:21caused by an event's sessionhandledCountbeing incremented by a subsequent call tonotify().Recent performance improvements have made this more likely to occur before the event uploader builds the JSON payload.
Changeset
A copy of the current session is now stored in
BugsnagEventso that subsequent calls tonotify()will not alter previous events' sessions.Removed some code duplication by consolidating handled and unhandled increments into
-incrementEventCountUnhandled:Testing
Reproduced by running the scenario locally.
Verified fix with a full E2E run - https://buildkite.com/bugsnag/bugsnag-cocoa/builds/2742