Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased default breadcrumb collection limit to 50 #1366

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Sep 13, 2021

Goal

Increases the default number of breadcrumbs collected to 50. This is required now that network breadcrumbs are anticipated to capture several more requests in a typical application, which would lead to increased breadcrumb churn at 25 items.

Changeset

  • Increased JVM and NDK limits to 50
  • Added a migration to copy breadcrumbs correctly from the old bugsnag_event struct to the new one
  • Altered setting of NDK user information, which was broken by increasing the breadcrumb array size in the struct

Testing

Updated existing test assertions. Added extra test cases for the NDK struct migration, which cover the first index in the ring buffer starting at 0 and non-zero values.

@fractalwrench fractalwrench changed the title feat: increase default maxBreadcrumbs to 50 Increase default maxBreadcrumbs to 50 Sep 13, 2021
@fractalwrench fractalwrench changed the title Increase default maxBreadcrumbs to 50 Increased default breadcrumb collection limit to 50 Sep 13, 2021
@fractalwrench fractalwrench force-pushed the PLAT-7213/increase-max-breadcrumbs branch 4 times, most recently from 1280c86 to 2e5b1cb Compare September 14, 2021 10:21
@fractalwrench fractalwrench force-pushed the PLAT-7213/increase-max-breadcrumbs branch from 2e5b1cb to f0905d7 Compare September 14, 2021 10:47
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1274.09 1161.32
arm64_v8a 405.9 295.31
armeabi -492.59 -21.55
armeabi_v7a 381.33 270.74
x86 446.84 336.25
x86_64 430.47 319.87

Generated by 🚫 Danger

@fractalwrench fractalwrench marked this pull request as ready for review September 14, 2021 12:49
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 24a0def into integration/ROAD-740/network-breadcrumbs Sep 14, 2021
@fractalwrench fractalwrench deleted the PLAT-7213/increase-max-breadcrumbs branch September 14, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants