Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Compatibility Improvements #17

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Claw256
Copy link
Contributor

@Claw256 Claw256 commented Mar 18, 2025

This PR adds several improvements for Windows compatibility:

  1. Added Windows compatibility to npm package with path normalization and executable detection
  2. Added Windows compatibility for MCP server with binary detection and path handling
  3. Added Windows installation and build documentation with Windows batch script
  4. Added Windows-specific Cargo release profile configurations

These changes make the probe tool more accessible and usable for Windows developers.

@buger
Copy link
Owner

buger commented Mar 19, 2025

Looks great!

Do you think #14 is absolute now?

Also you can run make fix-all to fix formatting issues and make tests pass.

@buger
Copy link
Owner

buger commented Mar 20, 2025

Do you think it is possible to fully get rid of Microsoft Visual C++ Redistributable 2015-2022 dependency, and statically link all needed depdendencies?

@Claw256
Copy link
Contributor Author

Claw256 commented Mar 20, 2025

Do you think it is possible to fully get rid of Microsoft Visual C++ Redistributable 2015-2022 dependency, and statically link all needed depdendencies?

For sure!

@Claw256
Copy link
Contributor Author

Claw256 commented Mar 20, 2025

I'll make the removal of the MSVC dependency into a new PR, as this PR is already getting big enough lol

@buger
Copy link
Owner

buger commented Mar 20, 2025

You have some merge conflicts now, once fixed will merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants