Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: deprecation go get gocov #2340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petersssong
Copy link
Contributor

Change Description

Description of change / link to associated issue.

go get currently modifies the go.mod file and that's probably not what you want installing a linter. Use go install instead.

ref:https://go.dev/doc/go-get-install-deprecation

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13850600604

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 55.305%

Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 80.95%
Totals Coverage Status
Change from base Build 13794438730: 0.0%
Covered Lines: 29936
Relevant Lines: 54129

💛 - Coveralls

@guggero
Copy link
Collaborator

guggero commented Mar 14, 2025

Thanks for the change. Though since goacc is declared as being deprecated now, I think we should use the native Golang coverage mechanism now. See lightningnetwork/lnd#9521 for an example.

@petersssong
Copy link
Contributor Author

Thanks for the change. Though since goacc is declared as being deprecated now, I think we should use the native Golang coverage mechanism now. See lightningnetwork/lnd#9521 for an example.

got, Should we use the native Golang coverage mechanism in current PR, or open a new one?

@guggero
Copy link
Collaborator

guggero commented Mar 14, 2025

I think you can change the PR title and content, so no need to create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants