multi: implement testnet4 and add support for soft forks that are always active #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
testnet4-bip9
branch
2 times, most recently
from
b2172bd to
c5ea1cc
Compare
Pull Request Test Coverage Report for Build 13818768992Details
💛 - Coveralls |
Roasbeef
commented
Mar 12, 2025
guggero
reviewed
Mar 12, 2025
| @@ -175,6 +175,10 @@ func (c customDeploymentChecker) Condition(_ *blockNode) (bool, error) { | |||
| return c.conditionTrue, nil | |||
| } | |||
|
|
|||
| func (c customDeploymentChecker) ForceActive(_ *blockNode) bool { | |||
There was a problem hiding this comment.
nit: Godoc comment missing.
There was a problem hiding this comment.
It's a mock version, none of the other existing methods have a godoc?
There was a problem hiding this comment.
Ah, yes. Missed that, sorry. Only looked at the diff and not the larger context of the file.
Add robust property-based tests for the assertNoTimeWarp function using the rapid testing library. The tests verify the following scenarios: - Basic property tests: - Only retarget blocks (block height divisible by blocksPerRetarget) are checked - Valid timestamps (within maxTimeWarp of previous block) pass validation - Invalid timestamps (too early) fail with appropriate ErrTimewarpAttack - Correct boundary behavior (exactly at maxTimeWarp limit) - Invariant tests: - Function never panics with valid inputs - Non-retarget blocks always return nil regardless of timestamps - Security tests: - All retarget blocks are protected from timewarp attacks - Non-retarget blocks are not affected by the timewarp check
…tion This commit introduces the concept of `AlwaysActiveHeight` to the deployment mechanism, allowing a deployment to be forced into the active state if the next block's height meets or exceeds this threshold. This is intended primarily to be used alongside the new Testnet4 deployment, as the past major soft forks are meant to be active from the very first block height.
Def, things like |
This was referenced Mar 12, 2025
guggero
approved these changes
Mar 12, 2025
| @@ -175,6 +175,10 @@ func (c customDeploymentChecker) Condition(_ *blockNode) (bool, error) { | |||
| return c.conditionTrue, nil | |||
| } | |||
|
|
|||
| func (c customDeploymentChecker) ForceActive(_ *blockNode) bool { | |||
There was a problem hiding this comment.
Ah, yes. Missed that, sorry. Only looked at the diff and not the larger context of the file.
| AlwaysActiveHeight: 1, | ||
| }, | ||
| DeploymentCSV: { | ||
| BitNumber: 29, |
There was a problem hiding this comment.
You mentioned the other day that the bit numbers probably shouldn't be the same for CSV and Segwit. Not sure if that's relevant given the AlwaysActiveHeight though.
| @@ -684,6 +689,12 @@ func compareScript(height int32, script []byte) error { | |||
| func CheckBlockHeaderContext(header *wire.BlockHeader, prevNode HeaderCtx, | |||
| flags BehaviorFlags, c ChainCtx, skipCheckpoint bool) error { | |||
|
|
|||
| // The height of this block is one more than the referenced previous | |||
| // block. | |||
| blockHeight := prevNode.Height() + 1 | |||
There was a problem hiding this comment.
nit: kinda weird this code block is moved here since blockHeight isn't used until line 729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken over from: #2318
Only the last commit is new.