Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: remove deprecated io/ioutil #2336

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

argentpapa
Copy link
Contributor

@argentpapa argentpapa commented Mar 9, 2025

Change Description

ioutil.ReadAll is deprecated: As of Go 1.16, this function simply calls io.ReadAll

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@guggero guggero merged commit 6afce8d into btcsuite:master Mar 10, 2025
3 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13746269182

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 3 files are covered.
  • 51 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 55.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/btcctl/config.go 0 1 0.0%
rpcclient/infrastructure.go 0 1 0.0%
rpcserver.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 15 73.57%
wire/msgaddrv2.go 16 51.72%
wire/netaddressv2.go 20 74.45%
Totals Coverage Status
Change from base Build 13719035689: -0.09%
Covered Lines: 29900
Relevant Lines: 54129

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants