feat: fix ci / makefile #2320
feat: fix ci / makefile #2320
Conversation
.github/workflows/go.yml
Outdated
| with: | ||
| go-version: ${{ env.GO_VERSION }} | ||
|
|
||
| - name: Check out source | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v4 |
|
|
||
| LINT_COMMIT := v1.18.0 | ||
| GOACC_COMMIT := 80342ae2e0fcf265e99e76bcc4efd022c7c3811b |
There was a problem hiding this comment.
So this is important, as it absolves any linter violations before that commit. Otherwise, we'll have to have a PR which fixes every linter violation.
In lnd, we use golangci which still supports this feature: https://github.com/lightningnetwork/lnd/pull/9382/files
scripts/tidy_modules.sh
Outdated
| @@ -1,17 +0,0 @@ | |||
| #!/bin/bash | |||
|
|
|||
| SUBMODULES=$(find . -mindepth 2 -name "go.mod" | cut -d'/' -f2) | |||
There was a problem hiding this comment.
Why remove? Given that it's able to locate sub-modules automatically?
In the new diff, we need to enumerate them all by hand.
There was a problem hiding this comment.
I just thought it was simple approach. Other commands, such as unit / unit-cover, are still done entirely by hand. It works perfectly as long as nested go.mod is not added.
Makefile
Outdated
|
|
||
| LINT = $(LINT_BIN) run -v $(LINT_WORKERS) | ||
| LINT = $(LINT_BIN) run -v $(LINT_WORKERS) --timeout=$(LINT_TIMEOUT) --issues-exit-code=0 |
There was a problem hiding this comment.
Why's issues-exit-code needed now?
There was a problem hiding this comment.
It just exits with code 0 when a lint error occurs. It's not needed, so better to remove it.
There was a problem hiding this comment.
resolved in bdf7318
| @@ -14,8 +14,6 @@ GOTEST_DEV = go test -v -tags=$(DEV_TAGS) | |||
| GOTEST := go test -v | |||
| GOMODTIDY := go mod tidy | |||
|
|
|||
| GOFILES_NOVENDOR = $(shell find . -type f -name '*.go' -not -path "./vendor/*") | |||
There was a problem hiding this comment.
👍 it's been years since we vendor'd deps
| @@ -146,7 +146,7 @@ func TestClientConnectedToWSServerRunner(t *testing.T) { | |||
| } | |||
|
|
|||
| testTable := []TestTableItem{ | |||
| TestTableItem{ | |||
| { | |||
There was a problem hiding this comment.
Were these the only instances in violation? If so then, perhaps we don't need that lint commit hash after all.
Was pretty sure we had some PRs merged in recent times that did things like violate the 80 char column limit.
There was a problem hiding this comment.
I do not know about commit history, but it is only change about make fmt.
There was a problem hiding this comment.
Not make lint - As far as I know, Go lint only gives warnings and doesn't change the code automatically.
|
Is this still under development? |
|
@yyforyongyu It is still in development, but it would be good to recreate the PR to follow Ideal Git Commit Structure. |
|
@rabbitprincess Cool thanks - I think it's better to do a force push on this PR once you fix the commit structure, it's easier that way as we won't lose the context/comments from this PR. |
Pull Request Test Coverage Report for Build 13760443534Details
💛 - Coveralls |
rabbitprincess
force-pushed
the
feature/fix-ci
branch
from
479ef5a to
52363a8
Compare
|
@yyforyongyu this pr and #2307 are force-pushed. can you review again? |
Overview
fix / cleanup makefile and correcting several commands.
Related to #2319 #2316