WIP: Add WIP feature support for w:moveTo and w:moveFrom #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be a good start for w:moveTo and w:moveFrom operations support. Currently, it allows to display moved elements using Paragraph::raw_text() without duplicating the text
|
PS: I did not run the docx-wasm tests as I do not have and cannot install the pnpm command on my company laptop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #794
This should be a good start for w:moveTo and w:moveFrom operations support. Currently, it allows to display moved elements using Paragraph::raw_text() without duplicating the text
What does this change?
Added
moveToandmoveFromenum variants forXMLElementandParagraphwith the needed refactor. Most changes are copy/pasted fromDeleteequivalents.Changed
Paragraph::raw_text()so that it displays moved elements correctly.WIP
This is WIP, some additional tests need to be written. For example, it should not be allowed to add a
moveFromelement without adding amoveToelement and vice versa. Also, there is some duplicated code that could probably be avoided with traits.I made this change as a quick fix for my needs for my work. As this change is enough for me to work, I cannot continue working on this project on my "working time", and I am not sure if I have enough free time to keep working on it.
Also, I’m not super familiar with the
.docxformat :DocumentChildvariants such asTable?MoveFromChildandMoveToChildvariants that should be taken into account ?Consider this a starter for a new feature implementation.