Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSIP 76: Threshold for price feeds through voting #222

Merged
merged 3 commits into from
Sep 26, 2019
Merged

BSIP 76: Threshold for price feeds through voting #222

merged 3 commits into from
Sep 26, 2019

Conversation

abitmore
Copy link
Member

Created bsip-0076.md.


In order to maintain the peg of the smartcoins, smartcoins holders now have the right to be always
possible to buy collateral at a "fair" price. For committee-owned smartcoins, the collateral is BTS.
However, when the BTS token is being dumped in Centralized Exchanges with fake volume and even fake supply,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please support these claims about something being "fake".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, whether fake or not is not the key point, even with true BTS someone can also do the shorting attack in CEX or even DEX, it's necessary to do feed price protection at some extreme scenario.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 'fake volume/supply short attack' conspiracy has been outright rejected by ZB: https://twitter.com/ZB_Group/status/1188771828967206912?s=20

for the benefit of the platform and the BTS token holders.
If a product brings more harm than benefit to the platform, its rules need to be optimized,
under extreme conditions, the product needs to be halted.
For smartcoins, when the cost to maintain the peg is too high to afford, it's time to give up the peg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cost for whom? Probably neither the asset owner nor the smartcoin holder.
So once again shorters are trying to bend the rules in their favour.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cost of the debt position owners, but also the whole ecosystem, including the asset owner and the smartcoin holder. the whole ecosystem suffer the low price and the shortage of smartcoin for long time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cost has been directly shifted onto the bitasset holder from the debtor, their assets have been devalued to spare debtors from global settlement outcome.

# Rationale

Ideally a smartcoin owner should be able to define a set of conditions about when to give up the peg
and how to de-peg, but it needs time to design and implement. Before the final solution got worked out,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ridiculous. The peg is the only thing that justifies the existence of the smartcoin.
Introducing new ways to deliberately de-peg undermines the whole concept of smartcoins. Once again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, peg is not the only thing, and it is ridiculous to maintain peg without considering the cost and supply.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No time was allocated to design and implement the de-pegging mechanism, given the pre-wp activation forced implementation & consequential BSIP still being written to maintain operation of bitassets in a de-pegged state.

The smartcoin owners didn't define this de-pegging outcome, it was instead forced onto price feed publishers without asset owner input.


# Specification

The BTS token holders define a threshold, if the market trading price of BTS is below the threshold,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The voting process is too slow to follow markets in any meaningful way.
The whole idea of setting an arbitrary threshold is absurd. What if I set up PC.USD with a value proposition like "This coin will always be worth 1 USD, except when I decide otherwise." How many would you buy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than one month later we still have the initial fake price feed 'threshold' set, the intention to vote on accurate price thresholds has failed to materialize.

witnesses should feed the threshold but not the market trading price, thus would effectively break
the peg as intended. When the market trading price of BTS is above the threshold, witnesses should
feed the market trading price, so the peg will be restored automatically. The mechanism is similar to
the Global-Settlement Protection mechanism as described in [BSIP 58](bsip-0058.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not.

  • GSP is not an arbitrary decision, it has a technical reason (undercollateralization).
  • GSP does not set an arbitrary threshold but has a precisely defined price.
  • GSP improves the value proposition of smartcoins because it replaces global(!) settlement with a mechanism that preserves collateral of other margin positions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global settlement protection through fraudulent price feeds is a betrayal of the smartcoin contract. If the protection was sufficiently described in 58 this BSIP would have been unneccessary.

Copy link
Contributor

@bitcrab bitcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to add below logic in price feeding to protect shorting attack:

if MA5<1.05*market price
   feed price = market price
else feed price =(MA5+market price)/2

@abitmore
Copy link
Member Author

@bitcrab as mentioned in the document, what value to be set as a threshold is not in the scope of this BSIP.


In order to maintain the peg of the smartcoins, smartcoins holders now have the right to be always
possible to buy collateral at a "fair" price. For committee-owned smartcoins, the collateral is BTS.
However, when the BTS token is being dumped in Centralized Exchanges with fake volume and even fake supply,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, whether fake or not is not the key point, even with true BTS someone can also do the shorting attack in CEX or even DEX, it's necessary to do feed price protection at some extreme scenario.

for the benefit of the platform and the BTS token holders.
If a product brings more harm than benefit to the platform, its rules need to be optimized,
under extreme conditions, the product needs to be halted.
For smartcoins, when the cost to maintain the peg is too high to afford, it's time to give up the peg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cost of the debt position owners, but also the whole ecosystem, including the asset owner and the smartcoin holder. the whole ecosystem suffer the low price and the shortage of smartcoin for long time.

# Rationale

Ideally a smartcoin owner should be able to define a set of conditions about when to give up the peg
and how to de-peg, but it needs time to design and implement. Before the final solution got worked out,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, peg is not the only thing, and it is ridiculous to maintain peg without considering the cost and supply.

However, when the BTS token is being dumped in Centralized Exchanges with fake volume and even fake supply,
the value of the token is distorted, thus, forcing BTS token holders who have their BTS token trapped in
debt positions as collateral to sell their collateral at the distorted price via margin calls or
force-settlements is unfair.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has always been a known risk for debtors; it's not unfair especially when these low prices have been sustained for over a month now.

the value of the token is distorted, thus, forcing BTS token holders who have their BTS token trapped in
debt positions as collateral to sell their collateral at the distorted price via margin calls or
force-settlements is unfair.
The same situation applies to non-committee-owned smart coins as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true across the board, some smartcoins (like the norns) are simply not exposed to external price references in their smartcoin price feed scripts.

The same situation applies to non-committee-owned smart coins as well.

Smartcoins are products of the BitShares platform, their rules are defined by the platform
for the benefit of the platform and the BTS token holders.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No benefit allocated to the smartcoin holder?

Smartcoins are products of the BitShares platform, their rules are defined by the platform
for the benefit of the platform and the BTS token holders.
If a product brings more harm than benefit to the platform, its rules need to be optimized,
under extreme conditions, the product needs to be halted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What when halting (faking price feeds) causes more damage than simply allowing a GS to trigger?

The platform itself doesn't rely on the state of bitassets, blocks will keep being produced after global settlement events.

and how to de-peg, but it needs time to design and implement. Before the final solution got worked out,
it's up to the price feed producers to execute the will for the asset owner on whether to maintain
the peg at a given point and how to de-peg. For committee-owned smartcoins, the owner is actually
all BTS holders who could express their will by voting, the price feed producers are the active witnesses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By voting to remove active witnesses? Because this BSIP was not voted into activation by the network prior to this BSIP being forced onto price feed publishers.

The BTS token holders define a threshold, if the market trading price of BTS is below the threshold,
witnesses should feed the threshold but not the market trading price, thus would effectively break
the peg as intended. When the market trading price of BTS is above the threshold, witnesses should
feed the market trading price, so the peg will be restored automatically. The mechanism is similar to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no price feed script changes to automatically switch over from fake price feeds to real feeds once the BTS price exceeds the set threshold? This probably won't be automatic since it's not been coded in such a manner

feed the market trading price, so the peg will be restored automatically. The mechanism is similar to
the Global-Settlement Protection mechanism as described in [BSIP 58](bsip-0058.md).

Changes to the threshold will be decided on individual committee-owned smartcoins by voting, each time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will this happen? It's been more than 1 month with the initially set fake price feeds. How long will this bailout last?


Poll-BSIP**-Not change bitCNY feed threshold [from the previous value when applicable] to 0.2 CNY per BTS

If the voting confirm the change, committee will announce the change at least 3 days before the change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 days is insufficient time to request price feed publishers to change their feeds & to change price feed scripts.


Some people think it's the debt position holders' responsibility to always maintain their
collateral ratio to a fair level. However, when the collateral's price can drop to zero due to
unfair manipulation, it's not possible to always maintain a good CR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no absolute proof of 'unfair manipulation' having taken place, in fact ZB outright refutes this accusation of yours: https://twitter.com/ZB_Group/status/1188771828967206912?s=20

It is the debtor's responsibility to maintain their collateral ratio, they fully acknowledged the risk of BTS price being influenced by CEX trading when they chose to open their market pegged asset debt positions, why bail out bad gamblers? No casino would allow you to take back your chips after you lost your hand.

When it's not possible to maintain your CR, you either get margin called or you trigger a global settlement. There was never an intended outcome where the bad debtor keeps their debt at the direct expense of the smartcoin holder & the network's branding.

Some people think it's the debt position holders' responsibility to always maintain their
collateral ratio to a fair level. However, when the collateral's price can drop to zero due to
unfair manipulation, it's not possible to always maintain a good CR.
Higher or lower, there is a point that the peg would break.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the peg breaks like this, global settlement should take place.

unfair manipulation, it's not possible to always maintain a good CR.
Higher or lower, there is a point that the peg would break.

This BSIP may negatively impact smartcoin holders since their holdings will likely devalue when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 'may', this BSIP did directly negatively impact smartcoin holders holding value, they now hold fraudulently valued assets instead of pegged assets which always adhere to their originally designed contract. CNY & USD experienced up to 30% devaluation in the last month after the forced implementation of this BSIP (prior to any related WP activating).


This BSIP may negatively impact smartcoin holders since their holdings will likely devalue when
the voted point is met, which would likely be worse than before.
Businesses built on top of the smartcoins may be impacted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, all CEX which have integrated bitassets are now indirectly misleading their users on the real value of the bitassets, further the asset details on the dex are now inaccurate (bitUSD != 1 USD anymore). Very little outreach to affected business parties seems to have taken place.

This BSIP may negatively impact smartcoin holders since their holdings will likely devalue when
the voted point is met, which would likely be worse than before.
Businesses built on top of the smartcoins may be impacted.
Reputation of smartcoins as well as the BitShares brand may be impacted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hertz used to reference bitUSD as a secure USD price feed source, it has now switched to a real USD:BTS price feed reference. bitUSD has directly lost credibility as a BTS:USD price reference on the DEX as a consequence of this BSIPs actions.

Businesses built on top of the smartcoins may be impacted.
Reputation of smartcoins as well as the BitShares brand may be impacted.

Discussions about changing the threshold to what value is not in the scope of this BSIP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then how/where/when should these take place? There was an intention for this to be voted upon, but no vote was completed before implementation and no further vote has taken place to set a new accurate price feed in over a month - this threshold now seems permanent until BTS recovers to above the threshold price. Quite misleading.

Reputation of smartcoins as well as the BitShares brand may be impacted.

Discussions about changing the threshold to what value is not in the scope of this BSIP.
The values should be carefully selected to comply with the market status and to mitigate potential risks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No proof of careful selection has been presented. Fixed fake prices have been set for over a month with no updated fake feed in sight. The real market status isn't being complied with & multiple risks were partly acknowledged but not mitigated at all.


Discussions about changing the threshold to what value is not in the scope of this BSIP.
The values should be carefully selected to comply with the market status and to mitigate potential risks.
Voters will need to evaluate each setting that is proposed in a BSIP poll.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voters were not able to fully evaluate this BSIP before the proposed changes were implemented on the main network.


# Non-Technical Summary

It is important to define a process for the BTS token holders to decide to change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTS token holders did not decide to implement this, it was implemented in advance of any WP activating.

@@ -0,0 +1,88 @@
BSIP: 0076
Title: Threshold for price feeds through voting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The polling mechanism was outright disregarded, this was implemented forcefully through coercion/intimidation of price feed publishers in advance of any related worker proposal activating. Inaccurate title, further no subsequent votes have taken place to set accurate feeds in over a month now. Seems highly misleading as a title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants