Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.0.3 renamed faded to graphical. Fixed for dark mode. #73

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

twobitunicorn
Copy link

Replaced faded with graphical for the dark modes. kept the original formatting. section of readme here.

  • Added the --graphical-fg variable to replace --faded-fg for borders.
    --faded-fg stays for disabled interactive elements.

    This change also includes the following renames:

    Old New
    --plain-faded-fg --plain-graphical-fg
    --info-faded-fg --info-graphical-fg
    --ok-faded-fg --ok-graphical-fg
    --warn-faded-fg --warn-graphical-fg
    --bad-faded-fg --bad-graphical-fg

@geoffrey-eisenbarth geoffrey-eisenbarth added bug Something isn't working visual A visual issue, affecting the appearance of pages. Can be usability-related or simply aesthetic. labels Feb 1, 2025
@geoffrey-eisenbarth
Copy link
Collaborator

Good catch, thanks for the PR! This might warrant a v1.2.0 as a "breaking" change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visual A visual issue, affecting the appearance of pages. Can be usability-related or simply aesthetic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants