Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only warn about init function being unset when it actually isn't set #151

Merged
merged 6 commits into from
Sep 27, 2017
Merged

Only warn about init function being unset when it actually isn't set #151

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
88d200f
Only warn about init function being unset when it actually isn't set
MatthewDarling Sep 26, 2017
6da8fd8
Check if *main-cli-fn* is a function
MatthewDarling Sep 26, 2017
d6ac79b
Improve error messages for default exception handler
MatthewDarling Sep 26, 2017
3a15618
More accurate message for non-function init
MatthewDarling Sep 27, 2017
6a71ebe
Improve logging for uncaught exceptions without stacktraces
MatthewDarling Sep 27, 2017
47d9145
Accomodate Karma log formats, and prefix ERROR to all error messages
MatthewDarling Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions library/src/doo/runner.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,22 @@

;; Karma starts the runner with arguments
(defn ^:export run! [a]
(try
(*main-cli-fn* a)
(catch :default e
(println "WARNING: doo's init function was not set")
(println e)
(exit! false))))
(if-not (fn? *main-cli-fn*)
(do (println "WARNING: doo's init function was not set or is not a function")
(exit! false))
(try
(*main-cli-fn* a)
(catch :default e
(println)
(println "ERROR: Exception outside tests:")
(println "ERROR:" e)
(if (.hasOwnProperty e "stack")
(do (println)
(println "ERROR: Stacktrace:")
(println "ERROR:" (.-stack e)))
(do (println)
(println "ERROR: No stacktrace available.")))
(exit! false)))))

(defn set-entry-point!
"Sets the function to be run when starting the script"
Expand Down